fix: Reintroduce JSpecify annotations. #1709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
JSpecify 1.0.0 has been released, so I'm hoping that googleapis#1362 is no longer a concern. (If there are remaining concerns, please do let me know.) This reverts commit 8138f46 (aka googleapis#1364) with a few changes: - This commit uses JSpecify 1.0.0 instead of 0.2.0. - As a result, it uses `org.jspecify.annotations` instead of `org.jspecify.nullness`. - It no longer touches `Structs`, since that was deleted in googleapis#1501. (JSpecify annotations were originally introduced by googleapis#1010.)
cpovirk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSpecify 1.0.0 has been released, so I'm hoping that
#1362 is no longer a
concern. (If there are remaining concerns, please do let me know.)
This reverts commit 8138f46 (aka
#1364) with a few
changes:
org.jspecify.annotationsinstead oforg.jspecify.nullness.Structs, since that was deleted infix: Replace internal Structs class with google-cloud-core version #1501.
(JSpecify annotations were originally introduced by
#1010.)