Skip to content

Commit 12f014d

Browse files
authored
feat: Make v1 the default protocolVersion (#2623)
1 parent 152702b commit 12f014d

File tree

1 file changed

+1
-10
lines changed
  • google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1

1 file changed

+1
-10
lines changed

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ public class Subscriber extends AbstractApiService implements SubscriberInterfac
144144
private final boolean maxDurationPerAckExtensionDefaultUsed;
145145
private final java.time.Duration minDurationPerAckExtension;
146146
private final boolean minDurationPerAckExtensionDefaultUsed;
147-
private final long protocolVersion;
147+
private final long protocolVersion = 1L;
148148

149149
// The ExecutorProvider used to generate executors for processing messages.
150150
private final ExecutorProvider executorProvider;
@@ -183,7 +183,6 @@ private Subscriber(Builder builder) {
183183
maxDurationPerAckExtensionDefaultUsed = builder.maxDurationPerAckExtensionDefaultUsed;
184184
minDurationPerAckExtension = builder.minDurationPerAckExtension;
185185
minDurationPerAckExtensionDefaultUsed = builder.minDurationPerAckExtensionDefaultUsed;
186-
protocolVersion = builder.protocolVersion;
187186

188187
clock = builder.clock.isPresent() ? builder.clock.get() : CurrentMillisClock.getDefaultClock();
189188

@@ -551,8 +550,6 @@ public static final class Builder {
551550
private boolean enableOpenTelemetryTracing = false;
552551
private OpenTelemetry openTelemetry = null;
553552

554-
private long protocolVersion = 0L;
555-
556553
private SubscriberShutdownSettings subscriberShutdownSettings =
557554
SubscriberShutdownSettings.newBuilder().build();
558555

@@ -776,12 +773,6 @@ Builder setClock(ApiClock clock) {
776773
return this;
777774
}
778775

779-
/** Gives the ability to override the protocol version */
780-
public Builder setProtocolVersion(long protocolVersion) {
781-
this.protocolVersion = protocolVersion;
782-
return this;
783-
}
784-
785776
/**
786777
* OpenTelemetry will be enabled if setEnableOpenTelemetry is true and and instance of
787778
* OpenTelemetry has been provied. Warning: traces are subject to change. The name and

0 commit comments

Comments
 (0)