Skip to content

Commit 0c01d49

Browse files
fix: Allow overriding the publisher in PartitionCountWatchingPublisherSettings (#1342)
1 parent f906d32 commit 0c01d49

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ If you are using Maven, add this to your pom.xml file:
3232
If you are using Gradle without BOM, add this to your dependencies:
3333

3434
```Groovy
35-
implementation 'com.google.cloud:google-cloud-pubsublite:1.10.0'
35+
implementation 'com.google.cloud:google-cloud-pubsublite:1.11.0'
3636
```
3737

3838
If you are using SBT, add this to your dependencies:
3939

4040
```Scala
41-
libraryDependencies += "com.google.cloud" % "google-cloud-pubsublite" % "1.10.0"
41+
libraryDependencies += "com.google.cloud" % "google-cloud-pubsublite" % "1.11.0"
4242
```
4343

4444
## Authentication

google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/PartitionCountWatchingPublisherSettings.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.cloud.pubsublite.internal.AlarmFactory;
2424
import com.google.cloud.pubsublite.internal.DefaultRoutingPolicy;
2525
import com.google.cloud.pubsublite.internal.Publisher;
26+
import com.google.cloud.pubsublite.internal.RoutingPolicy;
2627
import java.time.Duration;
2728

2829
@AutoValue
@@ -37,9 +38,12 @@ public abstract class PartitionCountWatchingPublisherSettings {
3738
// Optional parameters
3839
abstract Duration configPollPeriod();
3940

41+
abstract RoutingPolicy.Factory routingPolicyFactory();
42+
4043
public static Builder newBuilder() {
4144
return new AutoValue_PartitionCountWatchingPublisherSettings.Builder()
42-
.setConfigPollPeriod(Duration.ofMinutes(1));
45+
.setConfigPollPeriod(Duration.ofMinutes(1))
46+
.setRoutingPolicyFactory(DefaultRoutingPolicy::new);
4347
}
4448

4549
@AutoValue.Builder
@@ -54,13 +58,15 @@ public abstract static class Builder {
5458
// Optional parameters.
5559
public abstract Builder setConfigPollPeriod(Duration period);
5660

61+
public abstract Builder setRoutingPolicyFactory(RoutingPolicy.Factory factory);
62+
5763
public abstract PartitionCountWatchingPublisherSettings build();
5864
}
5965

6066
public Publisher<MessageMetadata> instantiate() throws ApiException {
6167
return new PartitionCountWatchingPublisher(
6268
publisherFactory(),
63-
DefaultRoutingPolicy::new,
69+
routingPolicyFactory(),
6470
new PartitionCountWatcherImpl.Factory(
6571
topic(), adminClient(), AlarmFactory.create(configPollPeriod())));
6672
}

0 commit comments

Comments
 (0)