Skip to content

Commit 747bc66

Browse files
fix: Make flogger a runtime dependency by default. (#265)
Fixes #213
1 parent ce39696 commit 747bc66

File tree

5 files changed

+4
-31
lines changed

5 files changed

+4
-31
lines changed

README.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@ If you are using Maven, add this to your pom.xml file:
2727
<artifactId>google-cloud-pubsub</artifactId>
2828
<version>1.108.1</version>
2929
</dependency>
30-
<!-- A logging dependency used by the underlying library -->
31-
<dependency>
32-
<groupId>com.google.flogger</groupId>
33-
<artifactId>flogger-system-backend</artifactId>
34-
<version>0.5.1</version>
35-
<scope>runtime</scope>
36-
</dependency>
3730

3831
```
3932

google-cloud-pubsublite/pom.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,15 @@
113113
<artifactId>grpc-protobuf</artifactId>
114114
</dependency>
115115

116-
<!--test dependencies-->
116+
<!-- Add system backend as a default dependency. This can be excluded if a different backend is needed.-->
117117
<dependency>
118118
<groupId>com.google.flogger</groupId>
119119
<artifactId>flogger-system-backend</artifactId>
120120
<version>0.5.1</version>
121-
<scope>test</scope>
121+
<scope>runtime</scope>
122122
</dependency>
123+
124+
<!--test dependencies-->
123125
<dependency>
124126
<groupId>com.google.truth</groupId>
125127
<artifactId>truth</artifactId>

pubsublite-beam-io/pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,6 @@
8484
</dependency>
8585

8686
<!--test dependencies-->
87-
<dependency>
88-
<groupId>com.google.flogger</groupId>
89-
<artifactId>flogger-system-backend</artifactId>
90-
<version>0.5.1</version>
91-
<scope>test</scope>
92-
</dependency>
9387
<dependency>
9488
<groupId>junit</groupId>
9589
<artifactId>junit</artifactId>
@@ -143,7 +137,6 @@
143137
<ignoredUnusedDeclaredDependencies>
144138
<ignoredUnusedDeclaredDependency>org.hamcrest:hamcrest</ignoredUnusedDeclaredDependency>
145139
<ignoredUnusedDeclaredDependency>io.grpc:grpc-testing</ignoredUnusedDeclaredDependency>
146-
<ignoredUnusedDeclaredDependency>com.google.flogger:flogger-system-backend</ignoredUnusedDeclaredDependency>
147140
<ignoredUnusedDeclaredDependency>org.apache.beam:beam-runners-direct-java</ignoredUnusedDeclaredDependency>
148141
<ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>
149142
</ignoredUnusedDeclaredDependencies>

samples/snapshot/pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,6 @@
5454
<version>1.108.1</version>
5555
</dependency>
5656

57-
<!-- A logging dependency used by the underlying library -->
58-
<dependency>
59-
<groupId>com.google.flogger</groupId>
60-
<artifactId>flogger-system-backend</artifactId>
61-
<version>0.5.1</version>
62-
<scope>runtime</scope>
63-
</dependency>
64-
6557
<dependency>
6658
<groupId>junit</groupId>
6759
<artifactId>junit</artifactId>

samples/snippets/pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,6 @@
5353
<artifactId>google-cloud-pubsub</artifactId>
5454
<version>1.108.1</version>
5555
</dependency>
56-
<!-- A logging dependency used by the underlying library -->
57-
<dependency>
58-
<groupId>com.google.flogger</groupId>
59-
<artifactId>flogger-system-backend</artifactId>
60-
<version>0.5.1</version>
61-
<scope>runtime</scope>
62-
</dependency>
6356
<!-- [END pubsublite_java_dependencies] -->
6457
<!-- [END pubsublite_install_without_bom] -->
6558

0 commit comments

Comments
 (0)