Skip to content

Commit c8504c3

Browse files
chore: Remove blanket disable of clirr, add gax files to clirr-ignored-differences.xml (#196)
1 parent a396f24 commit c8504c3

File tree

2 files changed

+50
-16
lines changed

2 files changed

+50
-16
lines changed

google-cloud-pubsublite/clirr-ignored-differences.xml

Lines changed: 50 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
33
<differences>
4+
<!-- TODO: remove after next version release -->
45
<difference>
5-
<!-- TODO: remove after next version release -->
66
<differenceType>6001</differenceType>
77
<className>com/google/cloud/pubsublite/AdminClientSettings</className>
88
<field>DEFAULT_RETRY_SETTINGS</field>
99
</difference>
10+
<difference>
11+
<differenceType>7013</differenceType>
12+
<className>com/google/cloud/pubsublite/cloudpubsub/SubscriberSettings*</className>
13+
<method>*</method>
14+
</difference>
15+
<!-- Blanket ignored files -->
1016
<difference>
1117
<differenceType>6000</differenceType>
1218
<className>com/google/cloud/pubsublite/internal/*</className>
@@ -93,4 +99,47 @@
9399
<differenceType>8001</differenceType>
94100
<className>com/google/cloud/pubsublite/cloudpubsub/internal/*</className>
95101
</difference>
102+
<difference>
103+
<differenceType>6000</differenceType>
104+
<className>com/google/cloud/pubsublite/v1/*</className>
105+
<method>*</method>
106+
</difference>
107+
<difference>
108+
<differenceType>6001</differenceType>
109+
<className>com/google/cloud/pubsublite/v1/*</className>
110+
<method>*</method>
111+
</difference>
112+
<difference>
113+
<differenceType>7001</differenceType>
114+
<className>com/google/cloud/pubsublite/v1/*</className>
115+
<method>*</method>
116+
</difference>
117+
<difference>
118+
<differenceType>7002</differenceType>
119+
<className>com/google/cloud/pubsublite/v1/*</className>
120+
<method>*</method>
121+
</difference>
122+
<difference>
123+
<differenceType>7011</differenceType>
124+
<className>com/google/cloud/pubsublite/v1/*</className>
125+
<method>*</method>
126+
</difference>
127+
<difference>
128+
<differenceType>7012</differenceType>
129+
<className>com/google/cloud/pubsublite/v1/*</className>
130+
<method>*</method>
131+
</difference>
132+
<difference>
133+
<differenceType>7013</differenceType>
134+
<className>com/google/cloud/pubsublite/v1/*</className>
135+
<method>*</method>
136+
</difference>
137+
<difference>
138+
<differenceType>8000</differenceType>
139+
<className>com/google/cloud/pubsublite/v1/*</className>
140+
</difference>
141+
<difference>
142+
<differenceType>8001</differenceType>
143+
<className>com/google/cloud/pubsublite/v1/*</className>
144+
</difference>
96145
</differences>

google-cloud-pubsublite/pom.xml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -215,21 +215,6 @@
215215
<groupId>org.codehaus.mojo</groupId>
216216
<artifactId>flatten-maven-plugin</artifactId>
217217
</plugin>
218-
<plugin>
219-
<!--TODO: Remove before GA. -->
220-
<groupId>org.codehaus.mojo</groupId>
221-
<artifactId>clirr-maven-plugin</artifactId>
222-
<configuration>
223-
<failOnError>false</failOnError>
224-
</configuration>
225-
<executions>
226-
<execution>
227-
<goals>
228-
<goal>check</goal>
229-
</goals>
230-
</execution>
231-
</executions>
232-
</plugin>
233218
</plugins>
234219
</build>
235220
</project>

0 commit comments

Comments
 (0)