Skip to content

Commit 4d72c4f

Browse files
authored
chore: remove workaround for non-public method (#1634)
* chore: remove workaround for non-public method * chore: add ignored diff to clirr
1 parent a893fca commit 4d72c4f

File tree

4 files changed

+6
-35
lines changed

4 files changed

+6
-35
lines changed

clirr-ignored-differences.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,8 @@
7272
<className>com/google/cloud/spanner/jdbc/CloudSpannerJdbcConnection</className>
7373
<method>void setProtoDescriptors(java.io.InputStream)</method>
7474
</difference>
75-
75+
<difference>
76+
<differenceType>8001</differenceType>
77+
<className>com/google/cloud/spanner/connection/ConnectionHelper</className>
78+
</difference>
7679
</differences>

src/main/java/com/google/cloud/spanner/connection/ConnectionHelper.java

Lines changed: 0 additions & 31 deletions
This file was deleted.

src/main/java/com/google/cloud/spanner/jdbc/AbstractJdbcConnection.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.google.cloud.spanner.Spanner;
2121
import com.google.cloud.spanner.SpannerException;
2222
import com.google.cloud.spanner.connection.AbstractStatementParser;
23-
import com.google.cloud.spanner.connection.ConnectionHelper;
2423
import com.google.cloud.spanner.connection.ConnectionOptions;
2524
import com.google.common.annotations.VisibleForTesting;
2625
import com.google.rpc.Code;
@@ -81,7 +80,7 @@ ConnectionOptions getConnectionOptions() {
8180
}
8281

8382
Spanner getSpanner() {
84-
return ConnectionHelper.getSpanner(this.spanner);
83+
return this.spanner.getSpanner();
8584
}
8685

8786
@Override

src/test/java/com/google/cloud/spanner/jdbc/ConcurrentTransactionOnEmulatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public static void startEmulator() {
5151
new GenericContainer<>(
5252
DockerImageName.parse("gcr.io/cloud-spanner-emulator/emulator:latest"))
5353
.withExposedPorts(9010)
54-
.waitingFor(Wait.forListeningPort());
54+
.waitingFor(Wait.forListeningPorts(9010));
5555
emulator.start();
5656
properties = new Properties();
5757
properties.setProperty("autoConfigEmulator", "true");

0 commit comments

Comments
 (0)