Skip to content

Commit 71441f7

Browse files
fix: findColumn is case-sensitive for unquoted identifier (#2261)
* fix: findColumn is case-sensitive for unquoted identifier * Addressed comments
1 parent 1054cdd commit 71441f7

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public boolean storesUpperCaseIdentifiers() {
187187

188188
@Override
189189
public boolean storesLowerCaseIdentifiers() {
190-
return false;
190+
return connection.getDialect() == Dialect.POSTGRESQL;
191191
}
192192

193193
@Override

src/test/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaDataTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public static Object[] data() {
6161
@Test
6262
public void testTrivialMethods() throws SQLException {
6363
JdbcConnection connection = mock(JdbcConnection.class);
64+
when(connection.getDialect()).thenReturn(dialect);
6465
DatabaseMetaData meta = new JdbcDatabaseMetaData(connection);
6566
assertTrue(meta.allProceduresAreCallable());
6667
assertTrue(meta.allTablesAreSelectable());
@@ -132,7 +133,11 @@ public void testTrivialMethods() throws SQLException {
132133
assertTrue(meta.nullPlusNonNullIsNull());
133134
assertFalse(meta.isCatalogAtStart());
134135
assertEquals(connection.isReadOnly(), meta.isReadOnly());
135-
assertFalse(meta.storesLowerCaseIdentifiers());
136+
if (dialect == Dialect.POSTGRESQL) {
137+
assertTrue(meta.storesLowerCaseIdentifiers());
138+
} else {
139+
assertFalse(meta.storesLowerCaseIdentifiers());
140+
}
136141
assertFalse(meta.storesLowerCaseQuotedIdentifiers());
137142
assertTrue(meta.storesMixedCaseIdentifiers());
138143
assertTrue(meta.storesMixedCaseQuotedIdentifiers());

0 commit comments

Comments
 (0)