Skip to content

Commit 7435890

Browse files
authored
test: remove some Emulator restrictions from tests (#2111)
Remove some specific checks/restrictions from tests when running on the Emulator, as these issues have been fixed in the latest release of the Emulator.
1 parent 619bea7 commit 7435890

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

src/test/java/com/google/cloud/spanner/jdbc/it/ITJdbcDatabaseMetaDataTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,6 @@ public void testGetColumns() throws SQLException {
313313
assertEquals(0, rs.getShort("SOURCE_DATA_TYPE"));
314314
assertTrue(rs.wasNull());
315315
assertEquals(col.computed ? "YES" : "NO", rs.getString("IS_GENERATEDCOLUMN"));
316-
// TODO: Remove check when the emulator correctly returns IS_IDENTITY
317-
if (!EmulatorSpannerHelper.isUsingEmulator()) {
318-
assertEquals(col.autoIncrement ? "YES" : "NO", rs.getString("IS_AUTOINCREMENT"));
319-
}
320316
assertEquals(24, rs.getMetaData().getColumnCount());
321317
}
322318
assertFalse(rs.next());
@@ -590,12 +586,6 @@ public void testGetIndexInfo() throws SQLException {
590586
connection.getMetaData().getIndexInfo(DEFAULT_CATALOG, schema, null, false, false)) {
591587

592588
for (IndexInfo index : EXPECTED_INDICES) {
593-
// The emulator does not generate indexes for foreign keys in a non-default schema.
594-
if (EmulatorSpannerHelper.isUsingEmulator()
595-
&& "test".equals(schema)
596-
&& ("FOREIGN_KEY".equals(index.indexName) || "GENERATED".equals(index.indexName))) {
597-
continue;
598-
}
599589
assertTrue(rs.next());
600590
assertEquals(DEFAULT_CATALOG, rs.getString("TABLE_CAT"));
601591
assertEquals(schema, rs.getString("TABLE_SCHEM"));

0 commit comments

Comments
 (0)