Skip to content

Commit b94e4c5

Browse files
authored
chore: support simple statement param metadata (#2163)
Add an option to use simple PreparedStatement ParameterMetadata that only uses client-side information. This prevents round-trips to Spanner when calling the method PreparedStatement#getParameterMetaData(), for example when these are triggered by frameworks like Spring Data. This option is experimental and could be removed in future releases. The option can be enabled by setting the system property `spanner.jdbc.use_simple_parameter_metadata=true`
1 parent 5893055 commit b94e4c5

File tree

4 files changed

+148
-5
lines changed

4 files changed

+148
-5
lines changed

src/main/java/com/google/cloud/spanner/jdbc/JdbcPreparedStatement.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.google.common.base.Preconditions;
3030
import com.google.common.collect.ImmutableList;
3131
import com.google.rpc.Code;
32+
import java.sql.ParameterMetaData;
3233
import java.sql.PreparedStatement;
3334
import java.sql.ResultSet;
3435
import java.sql.ResultSetMetaData;
@@ -117,8 +118,16 @@ public void addBatch() throws SQLException {
117118
}
118119

119120
@Override
120-
public JdbcParameterMetaData getParameterMetaData() throws SQLException {
121+
public ParameterMetaData getParameterMetaData() throws SQLException {
121122
checkClosed();
123+
124+
// NOTE: JdbcSimpleParameterMetaData is an experimental feature that can be removed without
125+
// warning in a future version. Your application should not assume that this feature will
126+
// continue to be supported.
127+
if (JdbcSimpleParameterMetaData.useSimpleParameterMetadata()) {
128+
return new JdbcSimpleParameterMetaData(this.parameters);
129+
}
130+
122131
if (cachedParameterMetadata == null) {
123132
if (getConnection().getParser().isUpdateStatement(sql)
124133
&& !getConnection().getParser().checkReturningClause(sql)) {
Lines changed: 102 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
1+
/*
2+
* Copyright 2025 Google LLC
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package com.google.cloud.spanner.jdbc;
18+
19+
import com.google.api.core.BetaApi;
20+
import com.google.cloud.spanner.connection.AbstractStatementParser.ParametersInfo;
21+
import java.sql.ParameterMetaData;
22+
import java.sql.SQLException;
23+
import java.sql.Types;
24+
25+
/**
26+
* {@link JdbcSimpleParameterMetaData} implements {@link ParameterMetaData} without a round-trip to
27+
* Spanner. This is an experimental feature that can be removed in a future version without prior
28+
* warning.
29+
*/
30+
@BetaApi
31+
class JdbcSimpleParameterMetaData implements ParameterMetaData {
32+
static final String USE_SIMPLE_PARAMETER_METADATA_KEY =
33+
"spanner.jdbc.use_simple_parameter_metadata";
34+
private final ParametersInfo parametersInfo;
35+
36+
/**
37+
* This is an experimental feature that can be removed in a future version without prior warning.
38+
*/
39+
@BetaApi
40+
static boolean useSimpleParameterMetadata() {
41+
return Boolean.parseBoolean(System.getProperty(USE_SIMPLE_PARAMETER_METADATA_KEY, "false"));
42+
}
43+
44+
JdbcSimpleParameterMetaData(ParametersInfo parametersInfo) {
45+
this.parametersInfo = parametersInfo;
46+
}
47+
48+
@Override
49+
public int getParameterCount() throws SQLException {
50+
return this.parametersInfo.numberOfParameters;
51+
}
52+
53+
@Override
54+
public int isNullable(int param) throws SQLException {
55+
return ParameterMetaData.parameterNullableUnknown;
56+
}
57+
58+
@Override
59+
public boolean isSigned(int param) throws SQLException {
60+
return false;
61+
}
62+
63+
@Override
64+
public int getPrecision(int param) throws SQLException {
65+
return 0;
66+
}
67+
68+
@Override
69+
public int getScale(int param) throws SQLException {
70+
return 0;
71+
}
72+
73+
@Override
74+
public int getParameterType(int param) throws SQLException {
75+
return Types.OTHER;
76+
}
77+
78+
@Override
79+
public String getParameterTypeName(int param) throws SQLException {
80+
return "unknown";
81+
}
82+
83+
@Override
84+
public String getParameterClassName(int param) throws SQLException {
85+
return Object.class.getName();
86+
}
87+
88+
@Override
89+
public int getParameterMode(int param) throws SQLException {
90+
return ParameterMetaData.parameterModeIn;
91+
}
92+
93+
@Override
94+
public <T> T unwrap(Class<T> iface) throws SQLException {
95+
throw new SQLException("This is not a wrapper for " + iface.getName());
96+
}
97+
98+
@Override
99+
public boolean isWrapperFor(Class<?> iface) throws SQLException {
100+
return false;
101+
}
102+
}

src/test/java/com/google/cloud/spanner/jdbc/JdbcPreparedStatementTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ public void testParameters() throws SQLException, MalformedURLException {
221221
ps.setObject(52, "{}", JsonType.VENDOR_TYPE_NUMBER);
222222
ps.setObject(53, "{}", PgJsonbType.VENDOR_TYPE_NUMBER);
223223

224-
JdbcParameterMetaData pmd = ps.getParameterMetaData();
224+
JdbcParameterMetaData pmd = (JdbcParameterMetaData) ps.getParameterMetaData();
225225
assertEquals(numberOfParams, pmd.getParameterCount());
226226
assertEquals(JdbcArray.class.getName(), pmd.getParameterClassName(1));
227227
assertEquals(ByteArrayInputStream.class.getName(), pmd.getParameterClassName(2));
@@ -281,7 +281,7 @@ public void testParameters() throws SQLException, MalformedURLException {
281281
assertEquals(String.class.getName(), pmd.getParameterClassName(51));
282282

283283
ps.clearParameters();
284-
pmd = ps.getParameterMetaData();
284+
pmd = (JdbcParameterMetaData) ps.getParameterMetaData();
285285
assertEquals(numberOfParams, pmd.getParameterCount());
286286
}
287287
}
@@ -329,12 +329,12 @@ public void testSetNullValues() throws SQLException {
329329
ps.setNull(++index, Types.NULL);
330330
assertEquals(numberOfParameters, index);
331331

332-
JdbcParameterMetaData pmd = ps.getParameterMetaData();
332+
JdbcParameterMetaData pmd = (JdbcParameterMetaData) ps.getParameterMetaData();
333333
assertEquals(numberOfParameters, pmd.getParameterCount());
334334
assertEquals(Timestamp.class.getName(), pmd.getParameterClassName(15));
335335

336336
ps.clearParameters();
337-
pmd = ps.getParameterMetaData();
337+
pmd = (JdbcParameterMetaData) ps.getParameterMetaData();
338338
assertEquals(numberOfParameters, pmd.getParameterCount());
339339
}
340340
}

src/test/java/com/google/cloud/spanner/jdbc/PreparedStatementParameterMetadataTest.java

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.google.cloud.spanner.Statement;
2525
import com.google.cloud.spanner.connection.AbstractMockServerTest;
2626
import com.google.cloud.spanner.connection.SpannerPool;
27+
import com.google.spanner.v1.ExecuteSqlRequest;
2728
import com.google.spanner.v1.ResultSet;
2829
import com.google.spanner.v1.ResultSetMetadata;
2930
import com.google.spanner.v1.ResultSetStats;
@@ -133,6 +134,7 @@ public void testAllTypesParameterMetadata_GoogleSql() throws SQLException {
133134
assertEquals(Types.ARRAY, metadata.getParameterType(++index));
134135
assertEquals("ARRAY<TIMESTAMP>", metadata.getParameterTypeName(index));
135136
}
137+
assertEquals(1, mockSpanner.countRequestsOfType(ExecuteSqlRequest.class));
136138
}
137139
}
138140

@@ -214,6 +216,36 @@ public void testAllTypesParameterMetadata_PostgreSQL() throws SQLException {
214216
assertEquals(Types.ARRAY, metadata.getParameterType(++index));
215217
assertEquals("timestamp with time zone[]", metadata.getParameterTypeName(index));
216218
}
219+
assertEquals(1, mockSpanner.countRequestsOfType(ExecuteSqlRequest.class));
220+
}
221+
}
222+
223+
@Test
224+
public void testSimpleJdbcParameterMetadata() throws SQLException {
225+
mockSpanner.putStatementResult(
226+
MockSpannerServiceImpl.StatementResult.detectDialectResult(Dialect.GOOGLE_STANDARD_SQL));
227+
String baseSql =
228+
"insert into all_types (col_bool, col_bytes, col_date, col_float32, col_float64, col_int64, "
229+
+ "col_json, col_numeric, col_string, col_timestamp, col_bool_array, col_bytes_array, "
230+
+ "col_date_array, col_float32_array, col_float64_array, col_int64_array, col_json_array,"
231+
+ "col_numeric_array, col_string_array, col_timestamp_array) values (%s)";
232+
String jdbcSql =
233+
String.format(
234+
baseSql,
235+
IntStream.range(0, 20).mapToObj(ignored -> "?").collect(Collectors.joining(", ")));
236+
237+
System.setProperty(JdbcSimpleParameterMetaData.USE_SIMPLE_PARAMETER_METADATA_KEY, "true");
238+
try (Connection connection = createJdbcConnection()) {
239+
try (PreparedStatement statement = connection.prepareStatement(jdbcSql)) {
240+
ParameterMetaData metadata = statement.getParameterMetaData();
241+
assertEquals(20, metadata.getParameterCount());
242+
for (int i = 0; i < metadata.getParameterCount(); i++) {
243+
assertEquals(Types.OTHER, metadata.getParameterType(i));
244+
}
245+
}
246+
assertEquals(0, mockSpanner.countRequestsOfType(ExecuteSqlRequest.class));
247+
} finally {
248+
System.clearProperty(JdbcSimpleParameterMetaData.USE_SIMPLE_PARAMETER_METADATA_KEY);
217249
}
218250
}
219251

0 commit comments

Comments
 (0)