Skip to content

Commit bd4dedd

Browse files
ci: javadoc job (JDK 17) in ci.yaml (#1819) (#1276)
1 parent 7481d12 commit bd4dedd

File tree

4 files changed

+23
-11
lines changed

4 files changed

+23
-11
lines changed

.github/.OwlBot.lock.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@
1313
# limitations under the License.
1414
docker:
1515
image: gcr.io/cloud-devrel-public-resources/owlbot-java:latest
16-
digest: sha256:32851debfefed2b66038e0141f1b5c2103bb59ba80b7475adbc10ef7abab3de7
17-
# created: 2023-06-22T15:06:52.039318836Z
16+
digest: sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9
17+
# created: 2023-06-27T18:51:58.922150125Z

.github/workflows/ci.yaml

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- uses: actions/checkout@v3
3131
- uses: actions/setup-java@v3
3232
with:
33-
distribution: zulu
33+
distribution: temurin
3434
java-version: ${{matrix.java}}
3535
- run: java -version
3636
- run: .kokoro/build.sh
@@ -45,7 +45,7 @@ jobs:
4545
- uses: actions/setup-java@v3
4646
with:
4747
java-version: 8
48-
distribution: zulu
48+
distribution: temurin
4949
- name: "Set jvm system property environment variable for surefire plugin (unit tests)"
5050
# Maven surefire plugin (unit tests) allows us to specify JVM to run the tests.
5151
# https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#jvm
@@ -54,7 +54,7 @@ jobs:
5454
- uses: actions/setup-java@v3
5555
with:
5656
java-version: 17
57-
distribution: zulu
57+
distribution: temurin
5858
- run: .kokoro/build.sh
5959
env:
6060
JOB_TYPE: test
@@ -66,7 +66,7 @@ jobs:
6666
- uses: actions/checkout@v3
6767
- uses: actions/setup-java@v3
6868
with:
69-
distribution: zulu
69+
distribution: temurin
7070
java-version: 8
7171
- run: java -version
7272
- run: .kokoro/build.bat
@@ -81,17 +81,29 @@ jobs:
8181
- uses: actions/checkout@v3
8282
- uses: actions/setup-java@v3
8383
with:
84-
distribution: zulu
84+
distribution: temurin
8585
java-version: ${{matrix.java}}
8686
- run: java -version
8787
- run: .kokoro/dependencies.sh
88+
javadoc:
89+
runs-on: ubuntu-latest
90+
steps:
91+
- uses: actions/checkout@v3
92+
- uses: actions/setup-java@v3
93+
with:
94+
distribution: temurin
95+
java-version: 17
96+
- run: java -version
97+
- run: .kokoro/build.sh
98+
env:
99+
JOB_TYPE: javadoc
88100
lint:
89101
runs-on: ubuntu-latest
90102
steps:
91103
- uses: actions/checkout@v3
92104
- uses: actions/setup-java@v3
93105
with:
94-
distribution: zulu
106+
distribution: temurin
95107
java-version: 11
96108
- run: java -version
97109
- run: .kokoro/build.sh
@@ -103,7 +115,7 @@ jobs:
103115
- uses: actions/checkout@v3
104116
- uses: actions/setup-java@v3
105117
with:
106-
distribution: zulu
118+
distribution: temurin
107119
java-version: 8
108120
- run: java -version
109121
- run: .kokoro/build.sh

.github/workflows/samples.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- uses: actions/checkout@v3
2424
- uses: actions/setup-java@v3
2525
with:
26-
distribution: zulu
26+
distribution: temurin
2727
java-version: 8
2828
- name: Run checkstyle
2929
run: mvn -P lint --quiet --batch-mode checkstyle:check

src/main/java/com/google/cloud/spanner/jdbc/CloudSpannerJdbcConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
* JDBC connection with a number of additional Cloud Spanner specific methods. JDBC connections that
3737
* are returned by the Cloud Spanner {@link JdbcDriver} will implement this interface.
3838
*
39-
* <p>Calling {@link Connection#unwrap(Class)} with {@link CloudSpannerJdbcConnection#getClass()} as
39+
* <p>Calling {@link Connection#unwrap(Class)} with {@code CloudSpannerJdbcConnection} class as
4040
* input on a {@link Connection} returned by the Cloud Spanner JDBC Driver will return a {@link
4141
* CloudSpannerJdbcConnection} instance.
4242
*/

0 commit comments

Comments
 (0)