Skip to content

Commit e6df56a

Browse files
committed
deps: remove duplicate dependencies
1 parent 1d89de5 commit e6df56a

File tree

2 files changed

+41
-13
lines changed

2 files changed

+41
-13
lines changed

pom.xml

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -200,39 +200,41 @@
200200
<scope>test</scope>
201201
</dependency>
202202

203-
<!-- Add OpenTelemetry implementation and exporters for use in integration tests -->
203+
<!--
204+
Add OpenTelemetry implementation and exporters for use in integration tests.
205+
They are added with compile scope, as the Spanner client requires these, and we do not want to
206+
reduce the scope in the JDBC driver.
207+
-->
204208
<dependency>
205209
<groupId>io.opentelemetry</groupId>
206-
<artifactId>opentelemetry-sdk-common</artifactId>
207-
<scope>test</scope>
210+
<artifactId>opentelemetry-context</artifactId>
208211
</dependency>
209212
<dependency>
210213
<groupId>io.opentelemetry</groupId>
211214
<artifactId>opentelemetry-sdk</artifactId>
212-
<scope>test</scope>
215+
</dependency>
216+
<dependency>
217+
<groupId>io.opentelemetry</groupId>
218+
<artifactId>opentelemetry-sdk-common</artifactId>
213219
</dependency>
214220
<dependency>
215221
<groupId>io.opentelemetry</groupId>
216222
<artifactId>opentelemetry-sdk-trace</artifactId>
217-
<scope>test</scope>
218223
</dependency>
219224
<dependency>
220225
<groupId>com.google.cloud.opentelemetry</groupId>
221226
<artifactId>exporter-trace</artifactId>
222-
<version>0.33.0</version>
223-
<scope>test</scope>
227+
<version>0.32.0</version>
224228
</dependency>
225229
<dependency>
226230
<groupId>com.google.cloud</groupId>
227231
<artifactId>google-cloud-trace</artifactId>
228-
<version>2.53.0</version>
229-
<scope>test</scope>
232+
<version>2.52.0</version>
230233
</dependency>
231234
<dependency>
232235
<groupId>com.google.api.grpc</groupId>
233236
<artifactId>proto-google-cloud-trace-v1</artifactId>
234-
<version>2.53.0</version>
235-
<scope>test</scope>
237+
<version>2.52.0</version>
236238
</dependency>
237239

238240
</dependencies>
@@ -361,7 +363,7 @@
361363
<ignoredUsedUndeclaredDependency>com.google.api.grpc:grpc-google-cloud-spanner-v1</ignoredUsedUndeclaredDependency>
362364
<ignoredUsedUndeclaredDependency>com.google.api.grpc:proto-google-cloud-spanner-admin-instance-v1</ignoredUsedUndeclaredDependency>
363365
<ignoredUsedUndeclaredDependency>com.google.api.grpc:proto-google-cloud-spanner-admin-database-v1</ignoredUsedUndeclaredDependency>
364-
<ignoredUsedUndeclaredDependency>io.opentelemetry:opentelemetry-api-incubator</ignoredUsedUndeclaredDependency>
366+
<ignoredUsedUndeclaredDependency>io.opentelemetry:*</ignoredUsedUndeclaredDependency>
365367
</ignoredUsedUndeclaredDependencies>
366368
<ignoredUnusedDeclaredDependencies>
367369
<!-- TODO: Remove grpc-alts from ignored list once it has been removed from java-spanner -->
@@ -371,7 +373,13 @@
371373
<ignoredDependency>com.google.api.grpc:grpc-google-cloud-spanner-v1</ignoredDependency>
372374
<ignoredDependency>com.google.api.grpc:grpc-google-cloud-spanner-admin-instance-v1</ignoredDependency>
373375
<ignoredDependency>com.google.api.grpc:grpc-google-cloud-spanner-admin-database-v1</ignoredDependency>
376+
<ignoredDependency>io.opentelemetry:*</ignoredDependency>
374377
</ignoredUnusedDeclaredDependencies>
378+
<ignoredNonTestScopedDependencies>
379+
<ignoredDependency>io.opentelemetry:*</ignoredDependency>
380+
<ignoredDependency>com.google.cloud:google-cloud-trace</ignoredDependency>
381+
<ignoredDependency>com.google.cloud.opentelemetry:exporter-trace</ignoredDependency>
382+
</ignoredNonTestScopedDependencies>
375383
</configuration>
376384
</plugin>
377385
</plugins>

src/test/java/com/google/cloud/spanner/jdbc/it/ITSingleJarTest.java

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,15 @@ public void setup() {
6161

6262
@Test
6363
public void testUseSingleJar() throws Exception {
64+
// printDeps();
6465
buildSingleJar();
6566
buildMainClass();
6667
runTestApplication();
6768
}
6869

6970
@Test
7071
public void testUseShadedJar() throws Exception {
72+
// printDeps();
7173
buildShadedJar();
7274
buildMainClass();
7375
runTestApplication();
@@ -91,6 +93,12 @@ private void runTestApplication() throws Exception {
9193
execute(builder);
9294
}
9395

96+
private void printDeps() throws Exception {
97+
ProcessBuilder builder = new ProcessBuilder();
98+
builder.command("mvn", "dependency:tree");
99+
execute(builder, true);
100+
}
101+
94102
private void buildSingleJar() throws Exception {
95103
ProcessBuilder builder = new ProcessBuilder();
96104
builder.command("mvn", "clean", "package", "-DskipTests", "-Dalt.build.dir=./target/single");
@@ -116,11 +124,23 @@ private void buildMainClass() throws Exception {
116124
}
117125

118126
private void execute(ProcessBuilder builder) throws Exception {
127+
execute(builder, false);
128+
}
129+
130+
private void execute(ProcessBuilder builder, boolean showOutput) throws Exception {
119131
Process process = builder.start();
120-
String errors;
132+
String errors, output = "";
121133
try (InputStreamReader reader = new InputStreamReader(process.getErrorStream())) {
122134
errors = CharStreams.toString(reader);
123135
}
136+
if (showOutput) {
137+
try (InputStreamReader reader = new InputStreamReader(process.getInputStream())) {
138+
output = CharStreams.toString(reader);
139+
}
140+
}
124141
assertEquals(errors, 0, process.waitFor());
142+
if (showOutput) {
143+
System.out.print(output);
144+
}
125145
}
126146
}

0 commit comments

Comments
 (0)