chore: Support PG Dialect in Hibernate #2238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
olavloite
reviewed
Oct 7, 2025
src/main/resources/com/google/cloud/spanner/jdbc/postgresql/DatabaseMetaData_GetColumns.sql
Show resolved
Hide resolved
product-auto-label
bot
added
size: m
sakthivelmanii
changed the title
sakthivelmanii
force-pushed
the
support_pg_dialect
branch
3 times, most recently
from
02d584b to
a5a3446
Compare
sakthivelmanii
force-pushed
the
support_pg_dialect
branch
from
a5a3446 to
7964273
Compare
olavloite
previously approved these changes
Oct 22, 2025
| * @return true if type name matches current type name or matches with one of postgres aliases | ||
| * or if it matches equivalent postgres type. | ||
| */ | ||
| public boolean matches(String typeName) { |
There was a problem hiding this comment.
Does this need to be public?
|
|
||
| public abstract Type getSpannerType(); | ||
|
|
||
| public Set<String> getAliases() { |
There was a problem hiding this comment.
Can we rename this to getPostgreSQLAliases()? The matches(..) method below confused me at first, and that was partly because it seemed like this could be any type of alias for the type.
olavloite
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
character varying[]is actually converted to Postgrestexttype Ref.typeNamecan be from Postgres dialect equivalent.