fix: Fix UTC<->Timezone conversion issue for DST start and end timestamp #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
sakthivelmanii
force-pushed
the
fix_dst_start_issue
branch
from
6984e99 to
09fa1a3
Compare
rahul2393
previously approved these changes
Oct 21, 2025
sakthivelmanii
force-pushed
the
fix_dst_start_issue
branch
from
09fa1a3 to
90c542e
Compare
olavloite
previously approved these changes
Oct 22, 2025
| assertThat(actual).isEqualTo(expected.withZoneSameInstant(timeZone.toZoneId())); | ||
| }); | ||
|
|
||
| TimeZone.setDefault(TimeZone.getDefault()); |
There was a problem hiding this comment.
nit: does this do anything? It seems to set the default to the current default
sakthivelmanii
force-pushed
the
fix_dst_start_issue
branch
from
90c542e to
44edf42
Compare
sakthivelmanii
changed the title
olavloite
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTC conversion issue:
Example date: 2018-03-25 01:00:00 UTC(or 2018-03-25 03:00:00+02:00)
Conversion to UTC
Original Epoch: 1 AM UTC (1521939600000) or 3 AM (Paris Time)
Calculated Offset: 2 hours ( 1 hr Raw Offset + 1 hr DST)
Offset Epoch: 11 PM UTC (1521932400000)
UTC to actual time
Original Epoch: 11 PM UTC (1521932400000 )
Calculated Offset: 1 hr ( 1hr Raw offset)
Timezone converted Epoch: 12 AM UTC(1521936000000)
We are losing 1hr because of DST. In order to solve this issue, we are adding timezone raw offset and DST savings so that it will handle the edge case when timestamp is start of DST.
Offset is purely computed on two fields. Raw offset and if time is within DST, then DST offset.