Skip to content

Commit 00a1735

Browse files
committed
Integration test for End to End tracing
1 parent a0806ee commit 00a1735

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

google-cloud-spanner/pom.xml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
<site.installationModule>google-cloud-spanner</site.installationModule>
1818
<opencensus.version>0.31.1</opencensus.version>
1919
<spanner.testenv.config.class>com.google.cloud.spanner.GceTestEnvConfig</spanner.testenv.config.class>
20-
<spanner.testenv.instance>projects/span-cloud-testing/instances/manu-demo1-mr-nam6</spanner.testenv.instance>
21-
<spanner.gce.config.project_id>span-cloud-testing</spanner.gce.config.project_id>
20+
<spanner.testenv.instance>projects/gcloud-devel/instances/spanner-testing-east1</spanner.testenv.instance>
21+
<spanner.gce.config.project_id>gcloud-devel</spanner.gce.config.project_id>
2222
<spanner.testenv.kms_key.name>projects/gcloud-devel/locations/us-east1/keyRings/cmek-test-key-ring/cryptoKeys/cmek-test-key</spanner.testenv.kms_key.name>
2323
</properties>
2424

@@ -461,18 +461,6 @@
461461
<version>0.33.0</version>
462462
<scope>test</scope>
463463
</dependency>
464-
<!-- <dependency>-->
465-
<!-- <groupId>com.google.cloud</groupId>-->
466-
<!-- <artifactId>google-cloud-trace</artifactId>-->
467-
<!-- <version>2.53.0</version>-->
468-
<!-- <scope>test</scope>-->
469-
<!-- </dependency>-->
470-
<!-- <dependency>-->
471-
<!-- <groupId>com.google.api.grpc</groupId>-->
472-
<!-- <artifactId>proto-google-cloud-trace-v1</artifactId>-->
473-
<!-- <version>2.53.0</version>-->
474-
<!-- <scope>test</scope>-->
475-
<!-- </dependency>-->
476464
</dependencies>
477465
<profiles>
478466
<profile>

google-cloud-spanner/src/test/java/com/google/cloud/spanner/IntegrationTestEnv.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,11 @@ protected void before() throws Throwable {
121121
assumeFalse(alwaysCreateNewInstance && isCloudDevel());
122122

123123
this.config.setUp();
124-
// OpenTelemetry with End to End tracing enabled for all integration test env. The grpc stub and connections are created during env set up using SpannerOptions and are reused for executing statements.
124+
// OpenTelemetry set up for enabling End to End tracing for all integration test env.
125+
// The grpc stub and connections are created during test env set up using SpannerOptions and are
126+
// reused for executing statements.
125127
SpannerOptions options = spannerOptionsWithEndToEndTracing();
126128
String instanceProperty = System.getProperty(TEST_INSTANCE_PROPERTY, "");
127-
instanceProperty = "projects/span-cloud-testing/instances/manu-demo1-mr-nam6";
128129
InstanceId instanceId;
129130
if (!instanceProperty.isEmpty() && !alwaysCreateNewInstance) {
130131
instanceId = InstanceId.of(instanceProperty);

0 commit comments

Comments
 (0)