Skip to content

Commit 049a5cd

Browse files
committed
test fix
1 parent 1783ab3 commit 049a5cd

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TraceWrapper.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class TraceWrapper {
6060
private final Tracer openCensusTracer;
6161
private final io.opentelemetry.api.trace.Tracer openTelemetryTracer;
6262
private final boolean enableExtendedTracing;
63-
private final AttributesBuilder commonAttributesBuilder;
63+
private final Attributes commonAttributes;
6464

6565
TraceWrapper(
6666
Tracer openCensusTracer,
@@ -69,7 +69,7 @@ class TraceWrapper {
6969
this.openTelemetryTracer = openTelemetryTracer;
7070
this.openCensusTracer = openCensusTracer;
7171
this.enableExtendedTracing = enableExtendedTracing;
72-
this.commonAttributesBuilder = createCommonAttributes();
72+
this.commonAttributes = createCommonAttributes();
7373
}
7474

7575
ISpan spanBuilder(String spanName) {
@@ -85,7 +85,8 @@ ISpan spanBuilder(String spanName, Attributes attributes) {
8585
return new OpenTelemetrySpan(
8686
openTelemetryTracer
8787
.spanBuilder(spanName)
88-
.setAllAttributes(this.commonAttributesBuilder.putAll(attributes).build())
88+
.setAllAttributes(attributes)
89+
.setAllAttributes(commonAttributes)
8990
.startSpan());
9091
} else {
9192
return new OpenCensusSpan(openCensusTracer.spanBuilder(spanName).startSpan());
@@ -221,13 +222,13 @@ Attributes createDatabaseAttributes(DatabaseId db) {
221222
return builder.build();
222223
}
223224

224-
private AttributesBuilder createCommonAttributes() {
225+
private Attributes createCommonAttributes() {
225226
AttributesBuilder builder = Attributes.builder();
226227
builder.put(GCP_CLIENT_SERVICE_KEY, "spanner");
227228
builder.put(GCP_CLIENT_REPO_KEY, "googleapis/java-spanner");
228229
builder.put(GCP_CLIENT_VERSION_KEY, GaxProperties.getLibraryVersion(TraceWrapper.class));
229230
builder.put(CLOUD_REGION_KEY, BuiltInMetricsProvider.detectClientLocation());
230-
return builder;
231+
return builder.build();
231232
}
232233

233234
private static String getTraceThreadName() {

0 commit comments

Comments
 (0)