Skip to content

Commit 0a74b9c

Browse files
committed
feat(spanner): added unit test
1 parent f1b5719 commit 0a74b9c

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseId.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public static DatabaseId of(String project, String instance, String database) {
9494
return new DatabaseId(new InstanceId(project, instance), database);
9595
}
9696

97-
/** Creates a {@code DatabaseId} given instance and database IDs. */
97+
/** Creates a {@code DatabaseId} with "default" project, given instance and database IDs. */
9898
public static DatabaseId of(String instance, String database) {
9999
return new DatabaseId(new InstanceId("default", instance), database);
100100
}

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionClientTests.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static org.junit.Assert.assertEquals;
2121
import static org.junit.Assert.assertNull;
2222
import static org.junit.Assert.assertTrue;
23+
import static org.junit.Assert.fail;
2324
import static org.mockito.ArgumentMatchers.any;
2425
import static org.mockito.Mockito.doNothing;
2526
import static org.mockito.Mockito.mock;
@@ -30,6 +31,7 @@
3031
import com.google.cloud.grpc.GrpcTransportOptions;
3132
import com.google.cloud.grpc.GrpcTransportOptions.ExecutorFactory;
3233
import com.google.cloud.spanner.SessionClient.SessionConsumer;
34+
import com.google.cloud.spanner.SessionClient.SessionId;
3335
import com.google.cloud.spanner.spi.v1.SpannerRpc;
3436
import com.google.cloud.spanner.spi.v1.SpannerRpc.Option;
3537
import com.google.common.collect.ImmutableMap;
@@ -503,4 +505,21 @@ public void onSessionCreateFailure(Throwable t, int createFailureForSessionCount
503505
}
504506
assertThat(returnedSessionCount.get()).isEqualTo(numSessions);
505507
}
508+
509+
@SuppressWarnings("unchecked")
510+
@Test
511+
public void testSessionNamePatterns() {
512+
// Valid pattern for host session name
513+
String host =
514+
"projects/spanner-project/instances/spanner-instance/databases/test-db/sessions/abcd1234";
515+
// Valid pattern for external host session name
516+
String externalHost = "instances/default/databases/test-db/sessions/abcd1234";
517+
try {
518+
SessionId.of(host);
519+
SessionId.of(externalHost);
520+
// If no exceptions are thrown, the test will pass
521+
} catch (IllegalArgumentException e) {
522+
fail("Expected no exception to be thrown, but got: " + e.getMessage());
523+
}
524+
}
506525
}

0 commit comments

Comments
 (0)