Skip to content

Commit 263901f

Browse files
feat(spanner): Removed env variable for Partitioned Ops ensuring that Multiplexed Session for Partitioned Ops is not available to customers.
1 parent 2db1cc6 commit 263901f

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

google-cloud-spanner-executor/src/main/java/com/google/cloud/spanner/SessionPoolOptionsHelper.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,12 @@ public static SessionPoolOptions.Builder setUseMultiplexedSessionForRW(
4444
SessionPoolOptions.Builder sessionPoolOptionsBuilder, boolean useMultiplexedSessionForRW) {
4545
return sessionPoolOptionsBuilder.setUseMultiplexedSessionForRW(useMultiplexedSessionForRW);
4646
}
47+
48+
// TODO: Remove when multiplexed session for partitioned operations are released.
49+
public static SessionPoolOptions.Builder setUseMultiplexedSessionForPartitionedOperations(
50+
SessionPoolOptions.Builder sessionPoolOptionsBuilder,
51+
boolean useMultiplexedSessionForPartitionedOps) {
52+
return sessionPoolOptionsBuilder.setUseMultiplexedSessionPartitionedOps(
53+
useMultiplexedSessionForPartitionedOps);
54+
}
4755
}

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,9 @@ private static Boolean getUseMultiplexedSessionFromEnvVariable() {
373373
@VisibleForTesting
374374
@InternalApi
375375
protected static Boolean getUseMultiplexedSessionFromEnvVariablePartitionedOps() {
376-
return parseBooleanEnvVariable("GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS");
376+
// Checks the value of env, GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS
377+
// This returns null until Partitioned Operations is supported.
378+
return null;
377379
}
378380

379381
private static Boolean parseBooleanEnvVariable(String variableName) {

google-cloud-spanner/src/test/java/com/google/cloud/spanner/BatchClientImplTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import com.google.spanner.v1.Session;
3737
import com.google.spanner.v1.Transaction;
3838
import io.opentelemetry.api.OpenTelemetry;
39-
4039
import java.time.Duration;
4140
import java.util.Collections;
4241
import java.util.Map;

0 commit comments

Comments
 (0)