Skip to content

Commit 33263f1

Browse files
committed
resolve comments
1 parent bee5966 commit 33263f1

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/ReadContext.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ public interface ReadContext extends AutoCloseable {
3333
enum QueryAnalyzeMode {
3434
/** Retrieves only the query plan information. No result data is returned. */
3535
PLAN,
36-
/** Retrieves both query plan and query execution statistics along with the result data. */
36+
/**
37+
* Retrieves the query plan, overall execution statistics, operator level execution statistics
38+
* along with the result data. This has a performance overhead compared to the other modes. It
39+
* isn't recommended to use this mode for production traffic.
40+
*/
3741
PROFILE,
3842
/**
3943
* Retrieves the overall (but not operator-level) execution statistics along with the result

google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ public void withStatsResult() {
494494
assertThat(resultSet.next()).isTrue();
495495
assertThat(resultSet.next()).isFalse();
496496
ResultSetStats receivedStats = resultSet.getStats();
497-
assertThat(stats).isEqualTo(receivedStats);
497+
assertThat(receivedStats).isEqualTo(stats);
498498
resultSet.close();
499499
}
500500

google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/it/ITReadWriteAutocommitSpannerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ public void test05_BatchUpdateWithException() {
183183
@Test
184184
public void test06_AnalyzeUpdate() {
185185
assumeFalse(
186-
"Emulator does not support PLAN, PROFILE, WITH_STATS AND WITH_PLAN_AND_STATS",
186+
"Emulator does not support PLAN, PROFILE, WITH_STATS, AND WITH_PLAN_AND_STATS",
187187
EmulatorSpannerHelper.isUsingEmulator());
188188

189189
// PLAN should not execute the update.

0 commit comments

Comments
 (0)