Skip to content

Commit 3cb1a59

Browse files
committed
chore(spanner): fix tests
1 parent 6101800 commit 3cb1a59

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

google-cloud-spanner/src/test/java/com/google/cloud/spanner/AsyncTransactionManagerImplTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ public void testRetryUsesPreviousTransactionIdOnMultiplexedSession() {
8989
new AsyncTransactionManagerImpl(session, span, Options.commitStats())) {
9090
manager.beginAsync();
9191

92-
// Verify that for the first transaction attempt, the `previousTransactionId` is null.
92+
// Verify that for the first transaction attempt, the `previousTransactionId` is ByteString.EMPTY.
9393
// This is because no transaction has been previously aborted at this point.
94-
verify(session).newTransaction(Options.fromTransactionOptions(Options.commitStats()), null);
94+
verify(session).newTransaction(Options.fromTransactionOptions(Options.commitStats()), ByteString.EMPTY);
9595
assertThrows(AbortedException.class, manager::commitAsync);
9696
clearInvocations(session);
9797

google-cloud-spanner/src/test/java/com/google/cloud/spanner/MultiplexedSessionDatabaseClientMockServerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ public void testAbortedReadWriteTxnUsesPreviousTxnIdOnRetryWithInlineBegin()
568568
.getMultiplexedSessionPreviousTransactionId());
569569
}
570570
*/
571-
571+
572572
// TODO(sriharshach): Uncomment test once Lock order preservation proto is published
573573
/*
574574
@Test

google-cloud-spanner/src/test/java/com/google/cloud/spanner/TransactionManagerImplTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,11 @@ public void storePreviousTxnIdOnAbortForMultiplexedSession() {
374374
txn = Mockito.mock(TransactionRunnerImpl.TransactionContextImpl.class);
375375
final ByteString mockTransactionId = ByteString.copyFromUtf8("mockTransactionId");
376376
txn.transactionId = mockTransactionId;
377-
when(session.newTransaction(Options.fromTransactionOptions(), null)).thenReturn(txn);
377+
when(session.newTransaction(Options.fromTransactionOptions(), ByteString.EMPTY)).thenReturn(txn);
378378
manager.begin();
379-
// Verify that for the first transaction attempt, the `previousTransactionId` is null.
379+
// Verify that for the first transaction attempt, the `previousTransactionId` is ByteString.EMPTY.
380380
// This is because no transaction has been previously aborted at this point.
381-
verify(session).newTransaction(Options.fromTransactionOptions(), null);
381+
verify(session).newTransaction(Options.fromTransactionOptions(), ByteString.EMPTY);
382382
doThrow(SpannerExceptionFactory.newSpannerException(ErrorCode.ABORTED, "")).when(txn).commit();
383383
assertThrows(AbortedException.class, () -> manager.commit());
384384

@@ -402,20 +402,20 @@ public void skipTxnIdStorageOnAbortForRegularSession() {
402402
txn = Mockito.mock(TransactionRunnerImpl.TransactionContextImpl.class);
403403
final ByteString mockTransactionId = ByteString.copyFromUtf8("mockTransactionId");
404404
txn.transactionId = mockTransactionId;
405-
when(session.newTransaction(Options.fromTransactionOptions(), null)).thenReturn(txn);
405+
when(session.newTransaction(Options.fromTransactionOptions(), ByteString.EMPTY)).thenReturn(txn);
406406
manager.begin();
407-
verify(session).newTransaction(Options.fromTransactionOptions(), null);
407+
verify(session).newTransaction(Options.fromTransactionOptions(), ByteString.EMPTY);
408408
doThrow(SpannerExceptionFactory.newSpannerException(ErrorCode.ABORTED, "")).when(txn).commit();
409409
assertThrows(AbortedException.class, () -> manager.commit());
410410
clearInvocations(session);
411411

412412
txn = Mockito.mock(TransactionRunnerImpl.TransactionContextImpl.class);
413-
when(session.newTransaction(Options.fromTransactionOptions(), null)).thenReturn(txn);
413+
when(session.newTransaction(Options.fromTransactionOptions(), ByteString.EMPTY)).thenReturn(txn);
414414
when(session.getIsMultiplexed()).thenReturn(false);
415415
assertThat(manager.resetForRetry()).isEqualTo(txn);
416416
// Verify that in the first retry attempt, the `previousTransactionId` is not passed to the new
417417
// transaction
418418
// in case of regular sessions.
419-
verify(session).newTransaction(Options.fromTransactionOptions(), null);
419+
verify(session).newTransaction(Options.fromTransactionOptions(), ByteString.EMPTY);
420420
}
421421
}

0 commit comments

Comments
 (0)