review comments

Author: surbhigarg92

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInOpenTelemetryMetricsProvider.java

@@ -91,22 +91,21 @@ Map<String, String> createClientAttributes(String projectId, String client_name)
     return clientAttributes;
   }
 
-  // Returns a 6-digit zero-padded all lower case hexadecimal representation
-  // of hash of the accounting group.
-  //
-  // The hash utilizes the 10 most significant bits of the value returned by
-  // `Hashing.goodFastHash(64).hashBytes()`, so effectively the returned values are
-  // uniformly distributed in the range [000000, 0003ff].
-  //
-  // The primary purpose of this function is to generate a hash value for the
-  // `client_hash` resource label using `client_uid` metric field.
-  //
-  // The range of values is chosen to be small enough to keep the cardinality of
-  // the Resource targets under control.
-  //
-  // Note: If at later time the range needs to be increased, it can be done by
-  // increasing the value of `kPrefixLength` to up to 24 bits without changing
-  // the format of the returned value.
+  /**
+   * Generates a 6-digit zero-padded all lower case hexadecimal representation of hash of the
+   * accounting group. The hash utilizes the 10 most significant bits of the value returned by
+   * `Hashing.goodFastHash(64).hashBytes()`, so effectively the returned values are uniformly
+   * distributed in the range [000000, 0003ff].
+   *
+   * <p>The primary purpose of this function is to generate a hash value for the `client_hash`
+   * resource label using `client_uid` metric field. The range of values is chosen to be small
+   * enough to keep the cardinality of the Resource targets under control. Note: If at later time
+   * the range needs to be increased, it can be done by increasing the value of `kPrefixLength` to
+   * up to 24 bits without changing the format of the returned value.
+   *
+   * @return Returns a 6-digit zero-padded all lower case hexadecimal representation of hash of the
+   *     accounting group.
+   */
   static String generateClientHash(String clientUid) {
     if (clientUid == null) {
       return "000000";

google-cloud-spanner/src/test/java/com/google/cloud/spanner/BuiltInOpenTelemetryMetricsProviderTest.java

@@ -16,7 +16,8 @@
 
 package com.google.cloud.spanner;
 
-import static com.google.common.truth.Truth.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -57,10 +58,9 @@ public void testGenerateClientHashWithSpecialCharacters() {
 
   private void verifyHash(String hash) {
     // Check if the hash length is 6
-    assertThat(hash.length()).isEqualTo(6);
+    assertEquals(hash.length(), 6);
     // Check if the hash is in the range [000000, 0003ff]
     long hashValue = Long.parseLong(hash, 16); // Convert hash from hex to decimal
-    assertThat(hashValue).isAtLeast(0);
-    assertThat(hashValue).isAtMost(0x3FF);
+    assertTrue(hashValue >= 0 && hashValue <= 0x3FF);
   }
 }