Skip to content

Commit 85ab665

Browse files
committed
Address code review comments
1 parent e429ad5 commit 85ab665

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

google-cloud-spanner/src/test/java/com/google/cloud/spanner/XGoogSpannerRequestIdTest.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616

1717
package com.google.cloud.spanner;
1818

19-
import static com.google.common.truth.Truth.assertThat;
19+
import static org.junit.Assert.assertEquals;
20+
import static org.junit.Assert.assertNotEquals;
21+
import static org.junit.Assert.assertTrue;
2022

2123
import java.util.regex.Matcher;
2224
import java.util.regex.Pattern;
@@ -26,28 +28,27 @@
2628

2729
@RunWith(JUnit4.class)
2830
public class XGoogSpannerRequestIdTest {
29-
private static String RAND_PROCESS_ID = XGoogSpannerRequestId.RAND_PROCESS_ID;
30-
private static Pattern REGEX_RAND_PROCESS_ID =
31+
private static final Pattern REGEX_RAND_PROCESS_ID =
3132
Pattern.compile("1.([0-9a-z]{8})(\\.\\d+){3}\\.(\\d+)$");
3233

3334
@Test
3435
public void testEquals() {
3536
XGoogSpannerRequestId reqID1 = XGoogSpannerRequestId.of(1, 1, 1, 1);
3637
XGoogSpannerRequestId reqID2 = XGoogSpannerRequestId.of(1, 1, 1, 1);
37-
assertThat(reqID1).isEqualTo(reqID2);
38-
assertThat(reqID1).isEqualTo(reqID1);
39-
assertThat(reqID2).isEqualTo(reqID2);
38+
assertEquals(reqID1, reqID2);
39+
assertEquals(reqID1, reqID1);
40+
assertEquals(reqID2, reqID2);
4041

4142
XGoogSpannerRequestId reqID3 = XGoogSpannerRequestId.of(1, 1, 1, 2);
42-
assertThat(reqID1).isNotEqualTo(reqID3);
43-
assertThat(reqID3).isNotEqualTo(reqID1);
44-
assertThat(reqID3).isEqualTo(reqID3);
43+
assertNotEquals(reqID1, reqID3);
44+
assertNotEquals(reqID3, reqID1);
45+
assertEquals(reqID3, reqID3);
4546
}
4647

4748
@Test
4849
public void testEnsureHexadecimalFormatForRandProcessID() {
4950
String str = XGoogSpannerRequestId.of(1, 2, 3, 4).toString();
50-
Matcher m = REGEX_RAND_PROCESS_ID.matcher(str);
51-
assertThat(m.matches()).isEqualTo(true);
51+
Matcher m = XGoogSpannerRequestIdTest.REGEX_RAND_PROCESS_ID.matcher(str);
52+
assertTrue(m.matches());
5253
}
5354
}

0 commit comments

Comments
 (0)