Skip to content

Commit 87dd1b4

Browse files
committed
feat(spanner): removing isExternalHost as a data member of the builder class
1 parent 3df1c90 commit 87dd1b4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionOptions.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,6 @@ public static Builder newBuilder() {
842842
private final Credentials fixedCredentials;
843843

844844
private final String host;
845-
private boolean isExternalHost;
846845
private final String projectId;
847846
private final String instanceId;
848847
private final String databaseName;
@@ -856,10 +855,10 @@ public static Builder newBuilder() {
856855

857856
private ConnectionOptions(Builder builder) {
858857
Matcher matcher;
859-
this.isExternalHost = false;
858+
boolean isExternalHost = false;
860859
if (builder.isValidExternalHostUri(builder.uri)) {
861860
matcher = Builder.EXTERNAL_HOST_PATTERN.matcher(builder.uri);
862-
this.isExternalHost = true;
861+
isExternalHost = true;
863862
} else {
864863
matcher = Builder.SPANNER_URI_PATTERN.matcher(builder.uri);
865864
}
@@ -982,7 +981,7 @@ && getInitialConnectionPropertyValue(OAUTH_TOKEN) == null
982981

983982
String projectId = "default";
984983
String instanceId = matcher.group(Builder.INSTANCE_GROUP);
985-
if (!this.isExternalHost) {
984+
if (!isExternalHost) {
986985
projectId = matcher.group(Builder.PROJECT_GROUP);
987986
} else if (instanceId == null) {
988987
instanceId = "default";

0 commit comments

Comments
 (0)