Skip to content

Commit 971475a

Browse files
committed
docs: added TODO for removing env checks for integration tests for UUID
1 parent 4bc6217 commit 971475a

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,9 @@ public void bindDateNull() {
426426

427427
@Test
428428
public void bindUuid() {
429+
// TODO: Remove once it is enabled in emulator.
429430
assumeFalse("Emulator does not support UUID yet", isUsingEmulator());
431+
// TODO: Remove once it is enabled in production universe.
430432
assumeTrue("UUID is currently only supported in cloud-devel", isUsingCloudDevel());
431433

432434
UUID uuid = UUID.randomUUID();
@@ -437,7 +439,9 @@ public void bindUuid() {
437439

438440
@Test
439441
public void bindUuidNull() {
442+
// TODO: Remove once it is enabled in emulator.
440443
assumeFalse("Emulator does not support UUID yet", isUsingEmulator());
444+
// TODO: Remove once it is enabled in production universe.
441445
assumeTrue("UUID is currently only supported in cloud-devel", isUsingCloudDevel());
442446

443447
Struct row =
@@ -841,7 +845,9 @@ public void bindDateArrayNull() {
841845

842846
@Test
843847
public void bindUuidArray() {
848+
// TODO: Remove once it is enabled in emulator.
844849
assumeFalse("Emulator does not support UUID yet", isUsingEmulator());
850+
// TODO: Remove once it is enabled in production universe.
845851
assumeTrue("UUID is currently only supported in cloud-devel", isUsingCloudDevel());
846852

847853
UUID u1 = UUID.randomUUID();
@@ -857,7 +863,9 @@ public void bindUuidArray() {
857863

858864
@Test
859865
public void bindUuidArrayEmpty() {
866+
// TODO: Remove once it is enabled in emulator.
860867
assumeFalse("Emulator does not support UUID yet", isUsingEmulator());
868+
// TODO: Remove once it is enabled in production universe.
861869
assumeTrue("UUID is currently only supported in cloud-devel", isUsingCloudDevel());
862870

863871
Struct row =
@@ -870,7 +878,9 @@ public void bindUuidArrayEmpty() {
870878

871879
@Test
872880
public void bindUuidArrayNull() {
881+
// TODO: Remove once it is enabled in emulator.
873882
assumeFalse("Emulator does not support UUID yet", isUsingEmulator());
883+
// TODO: Remove once it is enabled in production universe.
874884
assumeTrue("UUID is currently only supported in cloud-devel", isUsingCloudDevel());
875885

876886
Struct row =

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITUuidTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,12 @@ private static boolean isUsingCloudDevel() {
7171

7272
@Parameterized.Parameters(name = "Dialect = {0}")
7373
public static List<DialectTestParameter> data() {
74-
return Arrays.asList(
75-
new DialectTestParameter(Dialect.GOOGLE_STANDARD_SQL),
76-
new DialectTestParameter(Dialect.POSTGRESQL));
74+
// TODO: Remove once it is enabled in production universe.
75+
if (isUsingCloudDevel()) {
76+
return Arrays.asList(
77+
new DialectTestParameter(Dialect.GOOGLE_STANDARD_SQL),
78+
new DialectTestParameter(Dialect.POSTGRESQL));
79+
}
7780
}
7881

7982
@Parameterized.Parameter() public DialectTestParameter dialect;

0 commit comments

Comments
 (0)