Skip to content

Commit b43c263

Browse files
committed
chore(spanner): fix SpanTest unit test
1 parent 1e17e58 commit b43c263

File tree

1 file changed

+39
-2
lines changed
  • google-cloud-spanner/src/test/java/com/google/cloud/spanner

1 file changed

+39
-2
lines changed

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpanTest.java

Lines changed: 39 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,23 @@ public void transactionRunner() {
480480
"Request for 2 sessions returned 2 sessions",
481481
"Request for 1 multiplexed session returned 1 session",
482482
"Creating 2 sessions");
483-
if (isMultiplexedSessionsEnabled()) {
483+
List<String> expectedAnnotationsForMultiplexedSessionsRW =
484+
ImmutableList.of(
485+
"Starting Transaction Attempt",
486+
"Starting Commit",
487+
"Commit Done",
488+
"Transaction Attempt Succeeded",
489+
"Requesting 2 sessions",
490+
"Request for 2 sessions returned 2 sessions",
491+
"Request for 1 multiplexed session returned 1 session",
492+
"Creating 2 sessions");
493+
if (isMultiplexedSessionsEnabledForRW()) {
494+
verifyAnnotations(
495+
failOnOverkillTraceComponent.getAnnotations().stream()
496+
.distinct()
497+
.collect(Collectors.toList()),
498+
expectedAnnotationsForMultiplexedSessionsRW);
499+
} else if (isMultiplexedSessionsEnabled()) {
484500
verifyAnnotations(
485501
failOnOverkillTraceComponent.getAnnotations().stream()
486502
.distinct()
@@ -538,7 +554,21 @@ public void transactionRunnerWithError() {
538554
"Request for 1 multiplexed session returned 1 session",
539555
"Request for 2 sessions returned 2 sessions",
540556
"Creating 2 sessions");
541-
if (isMultiplexedSessionsEnabled()) {
557+
List<String> expectedAnnotationsForMultiplexedSessionsRW =
558+
ImmutableList.of(
559+
"Starting Transaction Attempt",
560+
"Transaction Attempt Failed in user operation",
561+
"Requesting 2 sessions",
562+
"Request for 1 multiplexed session returned 1 session",
563+
"Request for 2 sessions returned 2 sessions",
564+
"Creating 2 sessions");
565+
if (isMultiplexedSessionsEnabledForRW()) {
566+
verifyAnnotations(
567+
failOnOverkillTraceComponent.getAnnotations().stream()
568+
.distinct()
569+
.collect(Collectors.toList()),
570+
expectedAnnotationsForMultiplexedSessionsRW);
571+
} else if (isMultiplexedSessionsEnabled()) {
542572
verifyAnnotations(
543573
failOnOverkillTraceComponent.getAnnotations().stream()
544574
.distinct()
@@ -565,4 +595,11 @@ private boolean isMultiplexedSessionsEnabled() {
565595
}
566596
return spanner.getOptions().getSessionPoolOptions().getUseMultiplexedSession();
567597
}
598+
599+
private boolean isMultiplexedSessionsEnabledForRW() {
600+
if (spanner.getOptions() == null || spanner.getOptions().getSessionPoolOptions() == null) {
601+
return false;
602+
}
603+
return spanner.getOptions().getSessionPoolOptions().getUseMultiplexedSessionForRW();
604+
}
568605
}

0 commit comments

Comments
 (0)