Skip to content

Commit c18fec2

Browse files
committed
skip test and clirr
1 parent 1f87e91 commit c18fec2

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

google-cloud-spanner/clirr-ignored-differences.xml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -751,6 +751,13 @@
751751
<method>boolean isEnableBuiltInMetrics()</method>
752752
</difference>
753753

754+
<!-- Added Built In GRPC Metrics option -->
755+
<difference>
756+
<differenceType>7012</differenceType>
757+
<className>com/google/cloud/spanner/SpannerOptions$SpannerEnvironment</className>
758+
<method>boolean isEnableGRPCBuiltInMetrics()</method>
759+
</difference>
760+
754761
<!-- Added Monitoring host option -->
755762
<difference>
756763
<differenceType>7012</differenceType>
@@ -807,7 +814,7 @@
807814
<className>com/google/cloud/spanner/connection/Connection</className>
808815
<method>boolean isKeepTransactionAlive()</method>
809816
</difference>
810-
817+
811818
<!-- Automatic DML batching -->
812819
<difference>
813820
<differenceType>7012</differenceType>
@@ -839,7 +846,7 @@
839846
<className>com/google/cloud/spanner/connection/Connection</className>
840847
<method>boolean isAutoBatchDmlUpdateCountVerification()</method>
841848
</difference>
842-
849+
843850
<!-- Retry DML as Partitioned DML -->
844851
<difference>
845852
<differenceType>7012</differenceType>
@@ -863,7 +870,7 @@
863870
<className>com/google/cloud/spanner/connection/Connection</className>
864871
<method>java.lang.Object runTransaction(com.google.cloud.spanner.connection.Connection$TransactionCallable)</method>
865872
</difference>
866-
873+
867874
<!-- Added experimental host option -->
868875
<difference>
869876
<differenceType>7012</differenceType>

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBuiltInMetricsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public class ITBuiltInMetricsTest {
6161

6262
@BeforeClass
6363
public static void setUp() throws IOException {
64+
assumeFalse("This test requires credentials", EmulatorSpannerHelper.isUsingEmulator());
6465
metricClient = MetricServiceClient.create();
6566
// Enable BuiltinMetrics when the metrics are GA'ed
6667
db = env.getTestHelper().createTestDatabase();
@@ -76,7 +77,6 @@ public void tearDown() {
7677

7778
@Test
7879
public void testBuiltinMetricsWithDefaultOTEL() throws Exception {
79-
assumeFalse("This test requires credentials", EmulatorSpannerHelper.isUsingEmulator());
8080
// This stopwatch is used for to limit fetching of metric data in verifyMetrics
8181
Stopwatch metricsPollingStopwatch = Stopwatch.createStarted();
8282
Instant start = Instant.now().minus(Duration.ofMinutes(2));

0 commit comments

Comments
 (0)