chore(spanner): remove test skips

Author: harshachinta

google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ITAbstractSpannerTest.java

@@ -369,11 +369,4 @@ protected boolean indexExists(Connection connection, String table, String index)
     }
     return false;
   }
-
-  protected boolean isMultiplexedSessionsEnabledForRW(Spanner spanner) {
-    if (spanner.getOptions() == null || spanner.getOptions().getSessionPoolOptions() == null) {
-      return false;
-    }
-    return spanner.getOptions().getSessionPoolOptions().getUseMultiplexedSessionForRW();
-  }
 }

google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/OpenTelemetryTracingTest.java

@@ -112,9 +112,6 @@ Connection createTestConnection(String url) {
   public void testSingleUseQuery_withoutSqlStatement() {
     try (Connection connection = createTestConnection(getBaseUrl())) {
       connection.setAutocommit(true);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       try (ResultSet resultSet = connection.executeQuery(SELECT1_STATEMENT)) {
         assertTrue(resultSet.next());
         assertFalse(resultSet.next());
@@ -153,9 +150,6 @@ public boolean isEnableExtendedTracing() {
 
     try (Connection connection = createTestConnection(getBaseUrl())) {
       connection.setAutocommit(true);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       try (ResultSet resultSet = connection.executeQuery(SELECT1_STATEMENT)) {
         assertTrue(resultSet.next());
         assertFalse(resultSet.next());
@@ -192,9 +186,6 @@ public boolean isEnableExtendedTracing() {
   public void testSingleUseQuery() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(true);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       try (ResultSet resultSet = connection.executeQuery(SELECT1_STATEMENT)) {
         assertTrue(resultSet.next());
         assertFalse(resultSet.next());
@@ -230,9 +221,6 @@ public void testSingleUseUpdate() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(true);
       connection.executeUpdate(INSERT_STATEMENT);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
     }
     assertEquals(CompletableResultCode.ofSuccess(), spanExporter.flush());
     List<SpanData> spans = spanExporter.getFinishedSpanItems();
@@ -269,9 +257,6 @@ public void testSingleUseBatchUpdate() {
       connection.executeUpdate(INSERT_STATEMENT);
       connection.executeUpdate(INSERT_STATEMENT);
       connection.runBatch();
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
     }
     assertEquals(CompletableResultCode.ofSuccess(), spanExporter.flush());
     List<SpanData> spans = spanExporter.getFinishedSpanItems();
@@ -313,9 +298,6 @@ public void testSingleUseDdl() {
 
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(true);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.execute(Statement.of(ddl));
     }
     assertEquals(CompletableResultCode.ofSuccess(), spanExporter.flush());
@@ -334,9 +316,6 @@ public void testSingleUseDdlBatch() {
 
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(true);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.startBatchDdl();
       connection.execute(Statement.of(ddl1));
       connection.execute(Statement.of(ddl2));
@@ -354,9 +333,6 @@ public void testSingleUseDdlBatch() {
   public void testMultiUseReadOnlyQueries() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(false);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.setReadOnly(true);
       twice(
           () -> {
@@ -388,9 +364,6 @@ public void testMultiUseReadOnlyQueries() {
   public void testMultiUseReadWriteQueries() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(false);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.setReadOnly(false);
       twice(
           () -> {
@@ -425,9 +398,6 @@ public void testMultiUseReadWriteQueries() {
   public void testMultiUseReadWriteUpdates() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(false);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.setReadOnly(false);
       assertEquals(1L, connection.executeUpdate(INSERT_STATEMENT));
       assertEquals(1L, connection.executeUpdate(INSERT_STATEMENT));
@@ -457,9 +427,6 @@ public void testMultiUseReadWriteUpdates() {
   public void testMultiUseReadWriteBatchUpdates() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(false);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.setReadOnly(false);
 
       twice(
@@ -500,9 +467,6 @@ public void testMultiUseReadWriteBatchUpdates() {
   public void testMultiUseReadWriteAborted() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(false);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.setReadOnly(false);
       assertEquals(1L, connection.executeUpdate(INSERT_STATEMENT));
       mockSpanner.abortNextStatement();
@@ -551,9 +515,6 @@ public void testSavepoint() {
 
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(false);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.setReadOnly(false);
       connection.setSavepointSupport(SavepointSupport.ENABLED);
       assertEquals(1L, connection.executeUpdate(statement1));
@@ -603,9 +564,6 @@ public void testTransactionTag() {
     try (Connection connection = createTestConnection()) {
       connection.setAutocommit(false);
       connection.setReadOnly(false);
-      assumeFalse(
-          "OpenTelemetryTracingTest handler is not implemented for read-write with multiplexed sessions",
-          isMultiplexedSessionsEnabledForRW(connection.getSpanner()));
       connection.setTransactionTag("my_tag");
       assertEquals(1L, connection.executeUpdate(INSERT_STATEMENT));
       connection.commit();