Skip to content

Commit d47faea

Browse files
chore: generate libraries at Wed Sep 24 11:06:43 UTC 2025
1 parent ab78091 commit d47faea

File tree

2 files changed

+50
-41
lines changed

2 files changed

+50
-41
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -834,9 +834,7 @@ protected SpannerOptions(Builder builder) {
834834

835835
private String getResolvedUniverseDomain() {
836836
String universeDomain = getUniverseDomain();
837-
return Strings.isNullOrEmpty(universeDomain)
838-
? GOOGLE_DEFAULT_UNIVERSE
839-
: universeDomain;
837+
return Strings.isNullOrEmpty(universeDomain) ? GOOGLE_DEFAULT_UNIVERSE : universeDomain;
840838
}
841839

842840
/**

google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ConnectionOptionsTest.java

Lines changed: 49 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1339,62 +1339,73 @@ public void testUniverseDomain() {
13391339

13401340
// No universeDomain
13411341
AtomicBoolean executedConfigurator = new AtomicBoolean(false);
1342-
ConnectionOptions optionsWithNoUniverseDomainParam = ConnectionOptions.newBuilder()
1343-
.setUri("cloudspanner:/projects/default/instances/default/databases/singers-db")
1344-
.setConfigurator(optionsBuilder -> {
1345-
executedConfigurator.set(true);
1346-
SpannerOptions spannerOptions = optionsBuilder.build();
1347-
assertEquals("googleapis.com", spannerOptions.getUniverseDomain());
1348-
assertEquals("https://spanner.googleapis.com", spannerOptions.getHost());
1349-
})
1350-
.build();
1342+
ConnectionOptions optionsWithNoUniverseDomainParam =
1343+
ConnectionOptions.newBuilder()
1344+
.setUri("cloudspanner:/projects/default/instances/default/databases/singers-db")
1345+
.setConfigurator(
1346+
optionsBuilder -> {
1347+
executedConfigurator.set(true);
1348+
SpannerOptions spannerOptions = optionsBuilder.build();
1349+
assertEquals("googleapis.com", spannerOptions.getUniverseDomain());
1350+
assertEquals("https://spanner.googleapis.com", spannerOptions.getHost());
1351+
})
1352+
.build();
13511353
Spanner spanner = SpannerPool.INSTANCE.getSpanner(optionsWithNoUniverseDomainParam, connection);
13521354
spanner.close();
13531355
assertTrue(executedConfigurator.get());
13541356

13551357
executedConfigurator.set(false);
1356-
ConnectionOptions optionsWithUniverseDomainParam = ConnectionOptions.newBuilder()
1357-
.setUri("cloudspanner:/projects/default/instances/default/databases/singers-db;universeDomain=abc.goog")
1358-
.setConfigurator(optionsBuilder -> {
1359-
executedConfigurator.set(true);
1360-
SpannerOptions spannerOptions = optionsBuilder.build();
1361-
assertEquals("abc.goog", spannerOptions.getUniverseDomain());
1362-
assertEquals("https://spanner.abc.goog", spannerOptions.getHost());
1363-
})
1364-
.build();
1358+
ConnectionOptions optionsWithUniverseDomainParam =
1359+
ConnectionOptions.newBuilder()
1360+
.setUri(
1361+
"cloudspanner:/projects/default/instances/default/databases/singers-db;universeDomain=abc.goog")
1362+
.setConfigurator(
1363+
optionsBuilder -> {
1364+
executedConfigurator.set(true);
1365+
SpannerOptions spannerOptions = optionsBuilder.build();
1366+
assertEquals("abc.goog", spannerOptions.getUniverseDomain());
1367+
assertEquals("https://spanner.abc.goog", spannerOptions.getHost());
1368+
})
1369+
.build();
13651370
spanner = SpannerPool.INSTANCE.getSpanner(optionsWithUniverseDomainParam, connection);
13661371
spanner.close();
13671372
assertTrue(executedConfigurator.get());
13681373

13691374
executedConfigurator.set(false);
1370-
ConnectionOptions optionsWithHostAndUniverseDomainParam = ConnectionOptions.newBuilder()
1371-
.setUri("cloudspanner://spanner.abc.goog/projects/default/instances/default/databases/singers-db;universeDomain=abc.goog")
1372-
.setConfigurator(optionsBuilder -> {
1373-
executedConfigurator.set(true);
1374-
SpannerOptions spannerOptions = optionsBuilder.build();
1375-
assertEquals("abc.goog", spannerOptions.getUniverseDomain());
1376-
assertEquals("https://spanner.abc.goog", spannerOptions.getHost());
1377-
})
1378-
.build();
1375+
ConnectionOptions optionsWithHostAndUniverseDomainParam =
1376+
ConnectionOptions.newBuilder()
1377+
.setUri(
1378+
"cloudspanner://spanner.abc.goog/projects/default/instances/default/databases/singers-db;universeDomain=abc.goog")
1379+
.setConfigurator(
1380+
optionsBuilder -> {
1381+
executedConfigurator.set(true);
1382+
SpannerOptions spannerOptions = optionsBuilder.build();
1383+
assertEquals("abc.goog", spannerOptions.getUniverseDomain());
1384+
assertEquals("https://spanner.abc.goog", spannerOptions.getHost());
1385+
})
1386+
.build();
13791387
spanner = SpannerPool.INSTANCE.getSpanner(optionsWithHostAndUniverseDomainParam, connection);
13801388
spanner.close();
13811389
assertTrue(executedConfigurator.get());
13821390

13831391
executedConfigurator.set(false);
1384-
ConnectionOptions optionsWithLocalHostAndUniverseDomainParam = ConnectionOptions.newBuilder()
1385-
.setUri("cloudspanner://localhost:15000/projects/default/instances/default/databases/singers-db;usePlainText=true;universeDomain=abc.goog")
1386-
.setConfigurator(optionsBuilder -> {
1387-
executedConfigurator.set(true);
1388-
SpannerOptions spannerOptions = optionsBuilder.build();
1389-
assertEquals("abc.goog", spannerOptions.getUniverseDomain());
1390-
assertEquals("http://localhost:15000", spannerOptions.getHost());
1391-
})
1392-
.build();
1393-
spanner = SpannerPool.INSTANCE.getSpanner(optionsWithLocalHostAndUniverseDomainParam, connection);
1392+
ConnectionOptions optionsWithLocalHostAndUniverseDomainParam =
1393+
ConnectionOptions.newBuilder()
1394+
.setUri(
1395+
"cloudspanner://localhost:15000/projects/default/instances/default/databases/singers-db;usePlainText=true;universeDomain=abc.goog")
1396+
.setConfigurator(
1397+
optionsBuilder -> {
1398+
executedConfigurator.set(true);
1399+
SpannerOptions spannerOptions = optionsBuilder.build();
1400+
assertEquals("abc.goog", spannerOptions.getUniverseDomain());
1401+
assertEquals("http://localhost:15000", spannerOptions.getHost());
1402+
})
1403+
.build();
1404+
spanner =
1405+
SpannerPool.INSTANCE.getSpanner(optionsWithLocalHostAndUniverseDomainParam, connection);
13941406
spanner.close();
13951407
assertTrue(executedConfigurator.get());
13961408

1397-
13981409
connection.close();
13991410
}
14001411
}

0 commit comments

Comments
 (0)