Skip to content

Commit fafe22a

Browse files
committed
fix units
1 parent 439e105 commit fafe22a

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

google-cloud-spanner/src/test/java/com/google/cloud/spanner/BatchCreateSessionsSlowTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ public void testBatchCreateSessionsTimesOut_whenResourceExhausted() throws Excep
194194
List<ListenableFuture<Void>> futures = new ArrayList<>(5000);
195195
AtomicInteger counter = new AtomicInteger();
196196
for (int i = 0; i < 5000; i++) {
197-
final int index = i;
198197
futures.add(
199198
service.submit(
200199
() -> {

google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2868,7 +2868,8 @@ public void testPartitionedDmlDoesNotTimeout() {
28682868
DatabaseClient client =
28692869
spanner.getDatabaseClient(DatabaseId.of(TEST_PROJECT, TEST_INSTANCE, TEST_DATABASE));
28702870

2871-
assertThat(spanner.getOptions().getPartitionedDmlTimeout()).isEqualTo(Duration.ofHours(2L));
2871+
assertThat(spanner.getOptions().getPartitionedDmlTimeoutDuration())
2872+
.isEqualTo(Duration.ofHours(2L));
28722873

28732874
// PDML should not timeout with these settings.
28742875
long updateCount = client.executePartitionedUpdate(UPDATE_STATEMENT);
@@ -2904,7 +2905,8 @@ public void testPartitionedDmlWithLowerTimeout() {
29042905
try (Spanner spanner = builder.build().getService()) {
29052906
DatabaseClient client =
29062907
spanner.getDatabaseClient(DatabaseId.of(TEST_PROJECT, TEST_INSTANCE, TEST_DATABASE));
2907-
assertThat(spanner.getOptions().getPartitionedDmlTimeout()).isEqualTo(Duration.ofMillis(10L));
2908+
assertThat(spanner.getOptions().getPartitionedDmlTimeoutDuration())
2909+
.isEqualTo(Duration.ofMillis(10L));
29082910
// PDML should time out with these settings.
29092911
mockSpanner.setExecuteSqlExecutionTime(
29102912
SimulatedExecutionTime.ofMinimumAndRandomTime(1000, 0));

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -919,15 +919,15 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
919919
inputCallContext,
920920
CommitRequest.getDefaultInstance(),
921921
SpannerGrpc.getCommitMethod())
922-
.getTimeout())
922+
.getTimeoutDuration())
923923
.isEqualTo(Duration.ofSeconds(2L));
924924
assertThat(
925925
configurator
926926
.configure(
927927
inputCallContext,
928928
RollbackRequest.getDefaultInstance(),
929929
SpannerGrpc.getRollbackMethod())
930-
.getTimeout())
930+
.getTimeoutDuration())
931931
.isEqualTo(Duration.ofSeconds(8L));
932932

933933
assertNull(
@@ -941,15 +941,15 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
941941
inputCallContext,
942942
ExecuteSqlRequest.getDefaultInstance(),
943943
SpannerGrpc.getExecuteStreamingSqlMethod())
944-
.getTimeout())
944+
.getTimeoutDuration())
945945
.isEqualTo(Duration.ofSeconds(3L));
946946
assertThat(
947947
configurator
948948
.configure(
949949
inputCallContext,
950950
ExecuteBatchDmlRequest.getDefaultInstance(),
951951
SpannerGrpc.getExecuteBatchDmlMethod())
952-
.getTimeout())
952+
.getTimeoutDuration())
953953
.isEqualTo(Duration.ofSeconds(1L));
954954
assertNull(
955955
configurator.configure(
@@ -960,7 +960,7 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
960960
inputCallContext,
961961
ReadRequest.getDefaultInstance(),
962962
SpannerGrpc.getStreamingReadMethod())
963-
.getTimeout())
963+
.getTimeoutDuration())
964964
.isEqualTo(Duration.ofSeconds(7L));
965965

966966
assertThat(
@@ -969,15 +969,15 @@ public void testSpannerCallContextTimeoutConfigurator_WithTimeouts() {
969969
inputCallContext,
970970
PartitionQueryRequest.getDefaultInstance(),
971971
SpannerGrpc.getPartitionQueryMethod())
972-
.getTimeout())
972+
.getTimeoutDuration())
973973
.isEqualTo(Duration.ofSeconds(5L));
974974
assertThat(
975975
configurator
976976
.configure(
977977
inputCallContext,
978978
PartitionReadRequest.getDefaultInstance(),
979979
SpannerGrpc.getPartitionReadMethod())
980-
.getTimeout())
980+
.getTimeoutDuration())
981981
.isEqualTo(Duration.ofSeconds(6L));
982982
}
983983

0 commit comments

Comments
 (0)