Skip to content

Commit febeb30

Browse files
authored
Merge branch 'main' into mux-rw-it
2 parents 275c97a + c9f41f7 commit febeb30

File tree

4 files changed

+18
-14
lines changed

4 files changed

+18
-14
lines changed

benchmarks/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
<dependency>
8686
<groupId>io.opentelemetry</groupId>
8787
<artifactId>opentelemetry-bom</artifactId>
88-
<version>1.44.1</version>
88+
<version>1.46.0</version>
8989
<type>pom</type>
9090
<scope>import</scope>
9191
</dependency>

generation_config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
gapic_generator_version: 2.51.0
2-
googleapis_commitish: 00196e2a68b16a864c57db2e870822875a7f1198
1+
gapic_generator_version: 2.51.1
2+
googleapis_commitish: d581bbe1a66ad2e47eda2beebf6200f23b766ca9
33
libraries_bom_version: 26.52.0
44
libraries:
55
- api_shortname: spanner

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,20 @@ protected SpannerOptions(Builder builder) {
741741

742742
transportChannelExecutorThreadNameFormat = builder.transportChannelExecutorThreadNameFormat;
743743
channelProvider = builder.channelProvider;
744-
channelConfigurator = builder.channelConfigurator;
744+
if (builder.mTLSContext != null) {
745+
channelConfigurator =
746+
channelBuilder -> {
747+
if (builder.channelConfigurator != null) {
748+
channelBuilder = builder.channelConfigurator.apply(channelBuilder);
749+
}
750+
if (channelBuilder instanceof NettyChannelBuilder) {
751+
((NettyChannelBuilder) channelBuilder).sslContext(builder.mTLSContext);
752+
}
753+
return channelBuilder;
754+
};
755+
} else {
756+
channelConfigurator = builder.channelConfigurator;
757+
}
745758
interceptorProvider = builder.interceptorProvider;
746759
sessionPoolOptions =
747760
builder.sessionPoolOptions != null
@@ -1620,15 +1633,6 @@ public SpannerOptions build() {
16201633
// As we are using plain text, we should never send any credentials.
16211634
this.setCredentials(NoCredentials.getInstance());
16221635
}
1623-
if (mTLSContext != null) {
1624-
this.setChannelConfigurator(
1625-
builder -> {
1626-
if (builder instanceof NettyChannelBuilder) {
1627-
((NettyChannelBuilder) builder).sslContext(mTLSContext);
1628-
}
1629-
return builder;
1630-
});
1631-
}
16321636
if (this.numChannels == null) {
16331637
this.numChannels =
16341638
this.grpcGcpExtensionEnabled ? GRPC_GCP_ENABLED_DEFAULT_CHANNELS : DEFAULT_CHANNELS;

samples/snippets/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<dependency>
3535
<groupId>com.google.cloud</groupId>
3636
<artifactId>libraries-bom</artifactId>
37-
<version>26.50.0</version>
37+
<version>26.53.0</version>
3838
<type>pom</type>
3939
<scope>import</scope>
4040
</dependency>

0 commit comments

Comments
 (0)