feat: Require that all imports have a version contraints (#2331)

Fixes #1989 

This should not be landed before
googleapis/google-cloud-rust#3396

Author: brianquinlan

internal/sidekick/internal/dart/annotate.go

@@ -178,6 +178,13 @@ type annotateModel struct {
 	state *api.APIState
 	// The set of required imports (e.g. "package:google_cloud_type/type.dart" or
 	// "package:http/http.dart as http") that have been calculated.
+	//
+	// The keys of this map are used to determine what imports to include
+	// in the generated Dart code and what dependencies to include in
+	// pubspec.yaml.
+	//
+	// Every import must have a corresponding entry in .sidekick.toml to specify
+	// its version constraints.
 	imports map[string]bool
 	// The mapping from protobuf packages to Dart import statements.
 	packageMapping map[string]string
@@ -302,8 +309,10 @@ func (annotate *annotateModel) annotateModel(options map[string]string) error {
 	// Add the import for the google_cloud_gax package.
 	annotate.imports[commonImport] = true
 
-	packageDependencies := calculateDependencies(annotate.imports, annotate.dependencyConstraints)
-
+	packageDependencies, err := calculateDependencies(annotate.imports, annotate.dependencyConstraints)
+	if err != nil {
+		return err
+	}
 	ann := &modelAnnotations{
 		Parent:         model,
 		PackageName:    packageName(model, packageNameOverride),
@@ -359,7 +368,7 @@ func calculateRequiredFields(model *api.API) map[string]*api.Field {
 }
 
 // calculateDependencies calculates package dependencies based on `package:` imports.
-func calculateDependencies(imports map[string]bool, constraints map[string]string) []packageDependency {
+func calculateDependencies(imports map[string]bool, constraints map[string]string) ([]packageDependency, error) {
 	deps := []packageDependency{}
 
 	for imp := range imports {
@@ -371,9 +380,7 @@ func calculateDependencies(imports map[string]bool, constraints map[string]strin
 			}) {
 				constraint := constraints[name]
 				if len(constraint) == 0 {
-					// TODO(https://github.com/googleapis/librarian/issues/1989):
-					// Never emit "any" constraints.
-					constraint = "any"
+					return nil, fmt.Errorf("unknown version constraint for package %q (did you forget to add it to .sidekick.toml?)", name)
 				}
 				deps = append(deps, packageDependency{Name: name, Constraint: constraint})
 			}
@@ -384,7 +391,7 @@ func calculateDependencies(imports map[string]bool, constraints map[string]strin
 		return deps[i].Name < deps[j].Name
 	})
 
-	return deps
+	return deps, nil
 }
 
 func calculateImports(imports map[string]bool) []string {

internal/sidekick/internal/dart/annotate_test.go

@@ -15,18 +15,25 @@
 package dart
 
 import (
+	"maps"
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/googleapis/librarian/internal/sidekick/internal/api"
 	"github.com/googleapis/librarian/internal/sidekick/internal/sample"
 )
 
+var (
+	requiredConfig = map[string]string{
+		"package:google_cloud_gax": "^1.2.3",
+		"package:http":             "^4.5.6"}
+)
+
 func TestAnnotateModel(t *testing.T) {
 	model := api.NewTestAPI([]*api.Message{}, []*api.Enum{}, []*api.Service{})
 	model.PackageName = "test"
 	annotate := newAnnotateModel(model)
-	err := annotate.annotateModel(map[string]string{})
+	err := annotate.annotateModel(map[string]string{"package:google_cloud_gax": "^1.2.3"})
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -103,9 +110,9 @@ func TestAnnotateModel_Options(t *testing.T) {
 			},
 		},
 		{
-			map[string]string{"package:http": "1.2.0"},
+			map[string]string{"google_cloud_gax": "^1.2.3", "package:http": "1.2.0"},
 			func(t *testing.T, am *annotateModel) {
-				if diff := cmp.Diff(map[string]string{"http": "1.2.0"}, am.dependencyConstraints); diff != "" {
+				if diff := cmp.Diff(map[string]string{"google_cloud_gax": "^1.2.3", "http": "1.2.0"}, am.dependencyConstraints); diff != "" {
 					t.Errorf("mismatch in annotateModel.dependencyConstraints (-want, +got)\n:%s", diff)
 				}
 			},
@@ -114,7 +121,9 @@ func TestAnnotateModel_Options(t *testing.T) {
 
 	for _, tt := range tests {
 		annotate := newAnnotateModel(model)
-		err := annotate.annotateModel(tt.options)
+		options := maps.Clone(requiredConfig)
+		maps.Copy(options, tt.options)
+		err := annotate.annotateModel(maps.Clone(options))
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -140,7 +149,7 @@ func TestAnnotateMethod(t *testing.T) {
 	)
 	api.Validate(model)
 	annotate := newAnnotateModel(model)
-	err := annotate.annotateModel(map[string]string{})
+	err := annotate.annotateModel(requiredConfig)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -180,14 +189,17 @@ func TestCalculateDependencies(t *testing.T) {
 		{name: "package imports", imports: []string{
 			httpImport,
 			"package:google_cloud_foo/foo.dart",
-		}, want: []packageDependency{{Name: "google_cloud_foo", Constraint: "any"}, {Name: "http", Constraint: "^1.3.0"}}},
+		}, want: []packageDependency{{Name: "google_cloud_foo", Constraint: "^1.2.3"}, {Name: "http", Constraint: "^1.3.0"}}},
 	} {
 		t.Run(test.name, func(t *testing.T) {
 			deps := map[string]bool{}
 			for _, imp := range test.imports {
 				deps[imp] = true
 			}
-			got := calculateDependencies(deps, map[string]string{"http": "^1.3.0"})
+			got, err := calculateDependencies(deps, map[string]string{"google_cloud_foo": "^1.2.3", "http": "^1.3.0"})
+			if err != nil {
+				t.Fatal(err)
+			}
 
 			if diff := cmp.Diff(test.want, got); diff != "" {
 				t.Errorf("mismatch in calculateDependencies (-want, +got)\n:%s", diff)

internal/sidekick/internal/dart/generate_test.go

@@ -46,12 +46,16 @@ func TestFromProtobuf(t *testing.T) {
 			"googleapis-root": path.Join(testdataDir, "googleapis"),
 		},
 		Codec: map[string]string{
-			"copyright-year":              "2025",
-			"not-for-publication":         "true",
-			"version":                     "0.1.0",
-			"skip-format":                 "true",
-			"proto:google.protobuf":       "package:google_cloud_protobuf/protobuf.dart",
-			"proto:google.cloud.location": "package:google_cloud_location/location.dart",
+			"copyright-year":                "2025",
+			"not-for-publication":           "true",
+			"version":                       "0.1.0",
+			"skip-format":                   "true",
+			"package:google_cloud_gax":      "^1.2.3",
+			"package:http":                  "^4.5.6",
+			"package:google_cloud_location": "^7.8.9",
+			"package:google_cloud_protobuf": "^0.1.2",
+			"proto:google.protobuf":         "package:google_cloud_protobuf/protobuf.dart",
+			"proto:google.cloud.location":   "package:google_cloud_location/location.dart",
 		},
 	}
 	model, err := parser.CreateModel(cfg)
@@ -76,7 +80,7 @@ func TestFromProtobuf(t *testing.T) {
 func TestGeneratedFiles(t *testing.T) {
 	model := api.NewTestAPI([]*api.Message{}, []*api.Enum{}, []*api.Service{})
 	annotate := newAnnotateModel(model)
-	annotate.annotateModel(map[string]string{})
+	annotate.annotateModel(map[string]string{"package:google_cloud_gax": "^1.2.3", "package:http": "^4.5.6"})
 	files := generatedFiles(model)
 	if len(files) == 0 {
 		t.Errorf("expected a non-empty list of template files from generatedFiles()")