fix(internal/librarian): save librarian state in release init (#2034)

Write librarian state after updating libraries in release init.

Modify the test to check `state.yaml` in repo to verify the libraries
are updated.

Fixes #2030

Author: JoeWang1127

internal/librarian/release_init.go

@@ -126,6 +126,10 @@ func (r *initRunner) run(ctx context.Context) error {
 		return err
 	}
 
+	if err := saveLibrarianState(r.repo.GetDir(), r.state); err != nil {
+		return err
+	}
+
 	commitInfo := &commitInfo{
 		cfg:           r.cfg,
 		state:         r.state,

internal/librarian/release_init_test.go

@@ -22,6 +22,9 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/go-git/go-git/v5/plumbing"
+	"gopkg.in/yaml.v3"
+
 	"github.com/googleapis/librarian/internal/conventionalcommits"
 
 	"github.com/go-git/go-git/v5"
@@ -89,29 +92,33 @@ func TestInitRun(t *testing.T) {
 		name       string
 		runner     *initRunner
 		files      map[string]string
+		want       *config.LibrarianState
 		wantErr    bool
 		wantErrMsg string
 	}{
 		{
-			name: "run release init command for one library",
+			name: "run release init command for all libraries, update librarian state",
 			runner: &initRunner{
 				workRoot:        t.TempDir(),
 				containerClient: &mockContainerClient{},
-				cfg: &config.Config{
-					Library: "example-id",
-					Push:    false,
-				},
+				cfg:             &config.Config{},
 				state: &config.LibrarianState{
 					Libraries: []*config.LibraryState{
 						{
-							ID: "another-example-id",
+							ID:      "another-example-id",
+							Version: "1.0.0",
 							SourceRoots: []string{
 								"dir3",
 								"dir4",
 							},
+							RemoveRegex: []string{
+								"dir3",
+								"dir4",
+							},
 						},
 						{
-							ID: "example-id",
+							ID:      "example-id",
+							Version: "2.0.0",
 							SourceRoots: []string{
 								"dir1",
 								"dir2",
@@ -125,6 +132,30 @@ func TestInitRun(t *testing.T) {
 				},
 				repo: &MockRepository{
 					Dir: t.TempDir(),
+					GetCommitsForPathsSinceTagValueByTag: map[string][]*gitrepo.Commit{
+						"another-example-id-1.0.0": {
+							{
+								Hash:    plumbing.NewHash("123456"),
+								Message: "feat: another new feature",
+							},
+						},
+						"example-id-2.0.0": {
+							{
+								Hash:    plumbing.NewHash("abcdefg"),
+								Message: "feat: a new feature",
+							},
+						},
+					},
+					ChangedFilesInCommitValueByHash: map[string][]string{
+						plumbing.NewHash("123456").String(): {
+							"dir3/file3.txt",
+							"dir4/file4.txt",
+						},
+						plumbing.NewHash("abcdefg").String(): {
+							"dir1/file1.txt",
+							"dir2/file2.txt",
+						},
+					},
 				},
 				librarianConfig: &config.LibrarianConfig{},
 				partialRepo:     t.TempDir(),
@@ -133,15 +164,48 @@ func TestInitRun(t *testing.T) {
 				"file1.txt":      "",
 				"dir1/file1.txt": "",
 				"dir2/file2.txt": "",
+				"dir3/file3.txt": "",
+				"dir4/file4.txt": "",
+			},
+			want: &config.LibrarianState{
+				Libraries: []*config.LibraryState{
+					{
+						ID:      "another-example-id",
+						Version: "1.1.0", // version is bumped.
+						APIs:    []*config.API{},
+						SourceRoots: []string{
+							"dir3",
+							"dir4",
+						},
+						PreserveRegex: []string{},
+						RemoveRegex: []string{
+							"dir3",
+							"dir4",
+						},
+					},
+					{
+						ID:      "example-id",
+						Version: "2.1.0", // version is bumped.
+						APIs:    []*config.API{},
+						SourceRoots: []string{
+							"dir1",
+							"dir2",
+						},
+						PreserveRegex: []string{},
+						RemoveRegex: []string{
+							"dir1",
+							"dir2",
+						},
+					},
+				},
 			},
 		},
 		{
-			name: "run release init command without librarian config",
+			name: "run release init command for one library",
 			runner: &initRunner{
 				workRoot:        t.TempDir(),
 				containerClient: &mockContainerClient{},
 				cfg: &config.Config{
-					Push:    false,
 					Library: "example-id",
 				},
 				state: &config.LibrarianState{
@@ -169,20 +233,51 @@ func TestInitRun(t *testing.T) {
 				repo: &MockRepository{
 					Dir: t.TempDir(),
 				},
-				partialRepo: t.TempDir(),
+				librarianConfig: &config.LibrarianConfig{},
+				partialRepo:     t.TempDir(),
 			},
 			files: map[string]string{
 				"file1.txt":      "",
 				"dir1/file1.txt": "",
 				"dir2/file2.txt": "",
 			},
+			want: &config.LibrarianState{
+				Libraries: []*config.LibraryState{
+					{
+						ID:   "another-example-id",
+						APIs: []*config.API{},
+						SourceRoots: []string{
+							"dir3",
+							"dir4",
+						},
+						PreserveRegex: []string{},
+						RemoveRegex:   []string{},
+					},
+					{
+						ID:   "example-id",
+						APIs: []*config.API{},
+						SourceRoots: []string{
+							"dir1",
+							"dir2",
+						},
+						PreserveRegex: []string{},
+						RemoveRegex: []string{
+							"dir1",
+							"dir2",
+						},
+					},
+				},
+			},
 		},
 		{
-			name: "run release init command for all libraries",
+			name: "run release init command without librarian config",
 			runner: &initRunner{
 				workRoot:        t.TempDir(),
 				containerClient: &mockContainerClient{},
-				cfg:             &config.Config{},
+				cfg: &config.Config{
+					Push:    false,
+					Library: "example-id",
+				},
 				state: &config.LibrarianState{
 					Libraries: []*config.LibraryState{
 						{
@@ -191,10 +286,6 @@ func TestInitRun(t *testing.T) {
 								"dir3",
 								"dir4",
 							},
-							RemoveRegex: []string{
-								"dir3",
-								"dir4",
-							},
 						},
 						{
 							ID: "example-id",
@@ -212,17 +303,42 @@ func TestInitRun(t *testing.T) {
 				repo: &MockRepository{
 					Dir: t.TempDir(),
 				},
-				librarianConfig: &config.LibrarianConfig{},
-				partialRepo:     t.TempDir(),
+				partialRepo: t.TempDir(),
 			},
 			files: map[string]string{
 				"file1.txt":      "",
 				"dir1/file1.txt": "",
 				"dir2/file2.txt": "",
-				"dir3/file3.txt": "",
-				"dir4/file4.txt": "",
+			},
+			want: &config.LibrarianState{
+				Libraries: []*config.LibraryState{
+					{
+						ID:   "another-example-id",
+						APIs: []*config.API{},
+						SourceRoots: []string{
+							"dir3",
+							"dir4",
+						},
+						PreserveRegex: []string{},
+						RemoveRegex:   []string{},
+					},
+					{
+						ID:   "example-id",
+						APIs: []*config.API{},
+						SourceRoots: []string{
+							"dir1",
+							"dir2",
+						},
+						PreserveRegex: []string{},
+						RemoveRegex: []string{
+							"dir1",
+							"dir2",
+						},
+					},
+				},
 			},
 		},
+
 		{
 			name: "docker command returns error",
 			runner: &initRunner{
@@ -364,6 +480,19 @@ func TestInitRun(t *testing.T) {
 			files: map[string]string{
 				"dir1/file1.txt": "hello",
 			},
+			want: &config.LibrarianState{
+				Libraries: []*config.LibraryState{
+					{
+						ID:   "example-id",
+						APIs: []*config.API{},
+						SourceRoots: []string{
+							"dir1",
+						},
+						PreserveRegex: []string{},
+						RemoveRegex:   []string{},
+					},
+				},
+			},
 		},
 		{
 			name: "copy library files returns error",
@@ -484,6 +613,21 @@ func TestInitRun(t *testing.T) {
 			if err != nil {
 				t.Errorf("run() failed: %s", err.Error())
 			}
+			// load librarian state from state.yaml, which should contain updated
+			// library state.
+			bytes, err := os.ReadFile(filepath.Join(repoDir, ".librarian/state.yaml"))
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			var got *config.LibrarianState
+			if err := yaml.Unmarshal(bytes, &got); err != nil {
+				t.Fatal(err)
+			}
+
+			if diff := cmp.Diff(test.want, got); diff != "" {
+				t.Errorf("state mismatch (-want +got):\n%s", diff)
+			}
 		})
 	}
 }