impl(sidekick): find cargo manifest files (#2152)

Author: coryan

internal/sidekick/internal/rust_release/bump_versions.go

@@ -26,9 +26,10 @@ func BumpVersions(config *config.Release) error {
 	if err != nil {
 		return err
 	}
-	_, err = filesChangedSince(config, lastTag)
+	files, err := filesChangedSince(config, lastTag)
 	if err != nil {
 		return err
 	}
+	_ = findCargoManifests(files)
 	return nil
 }

internal/sidekick/internal/rust_release/bump_versions_test.go

@@ -127,6 +127,8 @@ func initRepositoryContents(t *testing.T) {
 		t.Fatal(err)
 	}
 	addCrate(t, path.Join("src", "storage"), "google-cloud-storage")
+	addCrate(t, path.Join("src", "gax-internal"), "google-cloud-gax-internal")
+	addCrate(t, path.Join("src", "gax-internal", "echo-server"), "echo-server")
 	addCrate(t, path.Join("src", "generated", "cloud", "secretmanager", "v1"), "google-cloud-secretmanager-v1")
 	if err := external.Run("git", "add", "."); err != nil {
 		t.Fatal(err)

internal/sidekick/internal/rust_release/find_cargo_manifests.go

@@ -0,0 +1,54 @@
+// Copyright 2025 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package rustrelease
+
+import (
+	"maps"
+	"os"
+	"path"
+	"slices"
+)
+
+func findCargoManifests(files []string) []string {
+	isCandidate := func(parent string) bool {
+		return parent != "/" && parent != "." && parent != ""
+	}
+	unique := map[string]bool{}
+	for _, f := range files {
+		if d := path.Dir(f); isCandidate(d) {
+			unique[d] = true
+		}
+	}
+
+	candidates := slices.Collect(maps.Keys(unique))
+	manifests := map[string]bool{}
+	for len(candidates) != 0 {
+		d := candidates[len(candidates)-1]
+		candidates = candidates[0 : len(candidates)-1]
+		manifest := path.Join(d, "Cargo.toml")
+		if _, ok := manifests[manifest]; ok {
+			continue
+		}
+		if _, err := os.Stat(manifest); err == nil {
+			manifests[manifest] = true
+		} else if parent := path.Dir(d); isCandidate(parent) {
+			candidates = append(candidates, parent)
+		}
+	}
+
+	list := slices.Collect(maps.Keys(manifests))
+	slices.Sort(list)
+	return list
+}

internal/sidekick/internal/rust_release/find_cargo_manifests_test.go

@@ -0,0 +1,45 @@
+// Copyright 2025 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package rustrelease
+
+import (
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+)
+
+func TestFindManifest(t *testing.T) {
+	setupForVersionBump(t, "find-manifest-0.0.1")
+	// A hypothetical set of file changes.
+	input := []string{
+		"doc/not-in-a-Cargo-file",
+		"doc/subdir/not-a-Cargo-file-either.md",
+		"src/storage/src/lib.rs",
+		"src/storage/src/generated/model.rs",
+		"src/storage/src/generated/stub.rs",
+		"src/storage/src/generated/client.rs",
+		"src/generated/cloud/secretmanager/v1/src/stub/subdir/file.rs",
+		"src/gax-internal/echo-server/src/lib.rs",
+	}
+	got := findCargoManifests(input)
+	want := []string{
+		"src/gax-internal/echo-server/Cargo.toml",
+		"src/generated/cloud/secretmanager/v1/Cargo.toml",
+		"src/storage/Cargo.toml",
+	}
+	if diff := cmp.Diff(want, got); diff != "" {
+		t.Errorf("generated files changed mismatch (-want +got):\n%s", diff)
+	}
+}