Skip to content

Commit 5235d26

Browse files
authored
test(internal/librarian): fix validation test (#1747)
Also put some more details in the error for debugging.
1 parent 9dfda5a commit 5235d26

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

internal/librarian/init.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ type initRunner struct {
5555

5656
func newInitRunner(cfg *config.Config) (*initRunner, error) {
5757
if ok, err := cfg.IsValid(); !ok || err != nil {
58-
return nil, fmt.Errorf("invalid config: %+v", cfg)
58+
return nil, fmt.Errorf("invalid config: %w", err)
5959
}
6060

6161
return &initRunner{

internal/librarian/init_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ func TestNewInitRunner(t *testing.T) {
3131
}{
3232
{
3333
name: "valid config",
34-
cfg: &config.Config{},
34+
cfg: &config.Config{
35+
Repo: "/tmp/repo",
36+
},
3537
},
3638
{
3739
name: "invalid config",
@@ -57,7 +59,7 @@ func TestNewInitRunner(t *testing.T) {
5759
return
5860
}
5961
if err != nil {
60-
t.Errorf("newInitRunner() got nil runner, want non-nil")
62+
t.Errorf("newInitRunner() = %v, want nil", err)
6163
}
6264
})
6365
}

0 commit comments

Comments
 (0)