fix(sidekick): missing field for discovery enums (#2361)

coryan · web-flow · commit 659ea3ade903 · 2025-09-25T14:12:08.000Z
diff --git a/internal/sidekick/internal/parser/discovery/enum.go b/internal/sidekick/internal/parser/discovery/enum.go
@@ -44,6 +44,7 @@ func makeMessageEnum(model *api.API, message *api.Message, name string, schema *
 			Parent:        enum,
 		}
 		enum.Values = append(enum.Values, value)
+		enum.UniqueNumberValues = append(enum.UniqueNumberValues, value)
 	}
 	model.State.EnumByID[enum.ID] = enum
 	message.Enums = append(message.Enums, enum)
diff --git a/internal/sidekick/internal/parser/discovery/enum_field_test.go b/internal/sidekick/internal/parser/discovery/enum_field_test.go
@@ -85,6 +85,7 @@ func TestMakeEnumFields(t *testing.T) {
 			},
 		},
 	}
+	wantEnum.UniqueNumberValues = wantEnum.Values
 	gotEnum, ok := model.State.EnumByID[wantEnum.ID]
 	if !ok {
 		t.Fatalf("missing enum %s", wantEnum.ID)

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ func makeMessageEnum(model api.API, message api.Message, name string, schema *`
`44`	`44`	`Parent: enum,`
`45`	`45`	`}`
`46`	`46`	`enum.Values = append(enum.Values, value)`
	`47`	`+ enum.UniqueNumberValues = append(enum.UniqueNumberValues, value)`
`47`	`48`	`}`
`48`	`49`	`model.State.EnumByID[enum.ID] = enum`
`49`	`50`	`message.Enums = append(message.Enums, enum)`
Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ func TestMakeEnumFields(t *testing.T) {`
`85`	`85`	`},`
`86`	`86`	`},`
`87`	`87`	`}`
	`88`	`+ wantEnum.UniqueNumberValues = wantEnum.Values`
`88`	`89`	`gotEnum, ok := model.State.EnumByID[wantEnum.ID]`
`89`	`90`	`if !ok {`
`90`	`91`	`t.Fatalf("missing enum %s", wantEnum.ID)`