Skip to content

Commit 7ef0103

Browse files
authored
fix(librarian): don't pass undocumented flags (#1834)
Fixes: #1829
1 parent 71a25ee commit 7ef0103

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

internal/docker/docker.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,6 @@ func (c *Docker) ReleaseInit(ctx context.Context, request *ReleaseInitRequest) e
267267
"--repo=/repo",
268268
"--output=/output",
269269
}
270-
if request.LibraryID != "" {
271-
commandArgs = append(commandArgs, fmt.Sprintf("--library=%s", request.LibraryID))
272-
}
273-
if request.LibraryVersion != "" {
274-
commandArgs = append(commandArgs, fmt.Sprintf("--library-version=%s", request.LibraryVersion))
275-
}
276270

277271
librarianDir := filepath.Join(request.PartialRepoDir, config.LibrarianDir)
278272
mounts := []string{

internal/docker/docker_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,6 @@ func TestDockerRun(t *testing.T) {
489489
"--librarian=/librarian",
490490
"--repo=/repo",
491491
"--output=/output",
492-
fmt.Sprintf("--library=%s", testLibraryID),
493492
},
494493
},
495494
{
@@ -528,8 +527,6 @@ func TestDockerRun(t *testing.T) {
528527
"--librarian=/librarian",
529528
"--repo=/repo",
530529
"--output=/output",
531-
fmt.Sprintf("--library=%s", testLibraryID),
532-
"--library-version=1.2.3",
533530
},
534531
},
535532
} {

0 commit comments

Comments
 (0)