Skip to content

Commit 8a9ec23

Browse files
brianquinlanbrianquinlan
authored
fix(dart): Fix decoding of repeated double fields. (#3166)
1. Replace having a bespoke `repeated` deserializer per primitive type, e.g. `decodeListBytes` with a list comprehension using the primitive decoder , e.g. `decodeBytes`. So the generated code looks like: ```dart switch (json['foo')) { null => [], List<Object?> $1 => [for (final i in $1) decodeBytes(i)], _ => throw FormatException('"foo" is not a list') } ``` 2. Do the same with `map` except use a map comprehension and decode both the key and value (I think that key decoding is incorrect because non-string keys are supported by proto - but that issue existed previously as well) 3. Expect that all decoders, e.g. `decodeBytes` return the correct type and that is not nullable. That means that the `null` guards have to be placed in the generated code. But it also means `!` isn't needed in the above list/map comprehensions. ```diff - decodeBytes(json['bytes']) ?? Uint8List(0) + switch (json['bytes']) { null => Uint8List(0), Object $1 => decodeBytes($1)} ``` 4. Change the signature of all decoders to be `Object?` so that we don't rely on `dynamic` to allow calls to succeed, e.g. ```diff - factory MyEnum.fromJson(String json) => MyEnum(json); + factory MyEnum.fromJson(Object? json) => MyEnum(json as String); ``` 5. Remove `// ignore_for_file: argument_type_not_assignable` from generated code because it is no longer needed after 1-4.
1 parent 6a89fd8 commit 8a9ec23

File tree

5 files changed

+157
-100
lines changed

5 files changed

+157
-100
lines changed

‎internal/sidekick/dart/annotate.go‎

Lines changed: 59 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -802,95 +802,85 @@ func (annotate *annotateModel) annotateField(field *api.Field) {
802802
}
803803
}
804804

805-
func (annotate *annotateModel) createFromJsonLine(field *api.Field, state *api.APIState, required bool) string {
806-
message := state.MessageByID[field.TypezID]
805+
func (annotate *annotateModel) decoder(typez api.Typez, typeid string, state *api.APIState) string {
806+
switch typez {
807+
case api.INT64_TYPE,
808+
api.UINT64_TYPE,
809+
api.SINT64_TYPE,
810+
api.FIXED64_TYPE,
811+
api.SFIXED64_TYPE:
812+
return "decodeInt64"
813+
case api.FLOAT_TYPE,
814+
api.DOUBLE_TYPE:
815+
return "decodeDouble"
816+
case api.INT32_TYPE,
817+
api.FIXED32_TYPE,
818+
api.SFIXED32_TYPE,
819+
api.SINT32_TYPE,
820+
api.UINT32_TYPE:
821+
return "decodeInt"
822+
case api.BOOL_TYPE:
823+
return "decodeBool"
824+
case api.STRING_TYPE:
825+
return "decodeString"
826+
case api.BYTES_TYPE:
827+
return "decodeBytes"
828+
case api.ENUM_TYPE:
829+
typeName := annotate.resolveEnumName(state.EnumByID[typeid])
830+
return fmt.Sprintf("%s.fromJson", typeName)
831+
case api.MESSAGE_TYPE:
832+
typeName := annotate.resolveMessageName(state.MessageByID[typeid], true)
833+
return fmt.Sprintf("%s.fromJson", typeName)
834+
default:
835+
panic("unknown type")
836+
}
837+
}
807838

839+
func (annotate *annotateModel) createFromJsonLine(field *api.Field, state *api.APIState, required bool) string {
808840
data := fmt.Sprintf("json['%s']", field.JSONName)
809841

810-
bang := ""
842+
defaultValue := "null"
811843
if required {
812844
switch {
813845
case field.Repeated:
814-
bang = " ?? []"
846+
defaultValue = "[]"
815847
case field.Map:
816-
bang = " ?? {}"
848+
defaultValue = "{}"
817849
case field.Typez == api.ENUM_TYPE:
818850
// 'ExecutableCode_Language.$default'
819851
typeName := annotate.resolveEnumName(annotate.state.EnumByID[field.TypezID])
820-
bang = fmt.Sprintf(" ?? %s.$default", typeName)
852+
defaultValue = fmt.Sprintf("%s.$default", typeName)
821853
default:
822-
bang = fmt.Sprintf(" ?? %s", defaultValues[field.Typez].Value)
854+
defaultValue = defaultValues[field.Typez].Value
823855
}
824856
}
825857

826858
switch {
859+
// Value.NullValue is encoded as null in JSON so lists and map values must match on nullable objects.
827860
case field.Repeated:
828-
switch field.Typez {
829-
case api.BYTES_TYPE:
830-
return fmt.Sprintf("decodeListBytes(%s)%s", data, bang)
831-
case api.ENUM_TYPE:
832-
typeName := annotate.resolveEnumName(state.EnumByID[field.TypezID])
833-
return fmt.Sprintf("decodeListEnum(%s, %s.fromJson)%s", data, typeName, bang)
834-
case api.MESSAGE_TYPE:
835-
_, hasCustomEncoding := usesCustomEncoding[field.TypezID]
836-
typeName := annotate.resolveMessageName(state.MessageByID[field.TypezID], true)
837-
if hasCustomEncoding {
838-
return fmt.Sprintf("decodeListMessageCustom(%s, %s.fromJson)%s", data, typeName, bang)
839-
} else {
840-
return fmt.Sprintf("decodeListMessage(%s, %s.fromJson)%s", data, typeName, bang)
841-
}
842-
default:
843-
return fmt.Sprintf("decodeList(%s)%s", data, bang)
844-
}
861+
decoder := annotate.decoder(field.Typez, field.TypezID, state)
862+
return fmt.Sprintf(
863+
"switch (%s) { null => %s, List<Object?> $1 => [for (final i in $1) %s(i)], "+
864+
"_ => throw FormatException('\"%s\" is not a list') }",
865+
data, defaultValue, decoder, field.JSONName)
845866
case field.Map:
846-
valueField := message.Fields[1]
847-
848-
switch valueField.Typez {
849-
case api.BYTES_TYPE:
850-
return fmt.Sprintf("decodeMapBytes(%s)%s", data, bang)
851-
case api.ENUM_TYPE:
852-
typeName := annotate.resolveEnumName(state.EnumByID[valueField.TypezID])
853-
return fmt.Sprintf("decodeMapEnum(%s, %s.fromJson)%s", data, typeName, bang)
854-
case api.MESSAGE_TYPE:
855-
_, hasCustomEncoding := usesCustomEncoding[valueField.TypezID]
856-
typeName := annotate.resolveMessageName(state.MessageByID[valueField.TypezID], true)
857-
if hasCustomEncoding {
858-
return fmt.Sprintf("decodeMapMessageCustom(%s, %s.fromJson)%s", data, typeName, bang)
859-
} else {
860-
return fmt.Sprintf("decodeMapMessage(%s, %s.fromJson)%s", data, typeName, bang)
861-
}
862-
default:
863-
return fmt.Sprintf("decodeMap(%s)%s", data, bang)
864-
}
865-
case field.Typez == api.INT64_TYPE ||
866-
field.Typez == api.UINT64_TYPE || field.Typez == api.SINT64_TYPE ||
867-
field.Typez == api.FIXED64_TYPE || field.Typez == api.SFIXED64_TYPE:
868-
return fmt.Sprintf("decodeInt64(%s)%s", data, bang)
869-
case field.Typez == api.FLOAT_TYPE || field.Typez == api.DOUBLE_TYPE:
870-
return fmt.Sprintf("decodeDouble(%s)%s", data, bang)
871-
case field.Typez == api.INT32_TYPE || field.Typez == api.FIXED32_TYPE ||
872-
field.Typez == api.SFIXED32_TYPE || field.Typez == api.SINT32_TYPE ||
873-
field.Typez == api.UINT32_TYPE ||
874-
field.Typez == api.BOOL_TYPE ||
875-
field.Typez == api.STRING_TYPE:
876-
return fmt.Sprintf("%s%s", data, bang)
877-
case field.Typez == api.BYTES_TYPE:
878-
return fmt.Sprintf("decodeBytes(%s)%s", data, bang)
879-
case field.Typez == api.ENUM_TYPE:
880-
typeName := annotate.resolveEnumName(state.EnumByID[field.TypezID])
881-
return fmt.Sprintf("decodeEnum(%s, %s.fromJson)%s", data, typeName, bang)
882-
case field.Typez == api.MESSAGE_TYPE:
883-
_, hasCustomEncoding := usesCustomEncoding[field.TypezID]
884-
typeName := annotate.resolveMessageName(state.MessageByID[field.TypezID], true)
885-
if hasCustomEncoding {
886-
return fmt.Sprintf("decodeCustom(%s, %s.fromJson)", data, typeName)
887-
} else {
888-
return fmt.Sprintf("decode(%s, %s.fromJson)", data, typeName)
889-
}
867+
message := state.MessageByID[field.TypezID]
868+
keyType := message.Fields[0].Typez
869+
keyTypeID := message.Fields[0].TypezID
870+
keyDecoder := annotate.decoder(keyType, keyTypeID, state)
871+
valueType := message.Fields[1].Typez
872+
valueTypeID := message.Fields[1].TypezID
873+
valueDecoder := annotate.decoder(valueType, valueTypeID, state)
874+
875+
return fmt.Sprintf(
876+
"switch (%s) { null => %s, Map<String, Object?> $1 => {for (final e in $1.entries) %s(e.key): %s(e.value)}, "+
877+
"_ => throw FormatException('\"%s\" is not an object') }",
878+
data, defaultValue, keyDecoder, valueDecoder, field.JSONName)
890879
}
891880

881+
decoder := annotate.decoder(field.Typez, field.TypezID, state)
892882
// No decoding necessary.
893-
return data
883+
return fmt.Sprintf("switch (%s) { null => %s, Object $1 => %s($1)}", data, defaultValue, decoder)
894884
}
895885

896886
func createToJsonLine(field *api.Field, state *api.APIState, required bool) string {

‎internal/sidekick/dart/annotate_test.go‎

Lines changed: 82 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -852,91 +852,151 @@ func TestCreateFromJsonLine(t *testing.T) {
852852
// primitives
853853
{
854854
&api.Field{Name: "bool", JSONName: "bool", Typez: api.BOOL_TYPE},
855-
"json['bool'] ?? false",
855+
"switch (json['bool']) { null => false, Object $1 => decodeBool($1)}",
856856
}, {
857857
&api.Field{Name: "bytes", JSONName: "bytes", Typez: api.BYTES_TYPE},
858-
"decodeBytes(json['bytes']) ?? Uint8List(0)",
858+
"switch (json['bytes']) { null => Uint8List(0), Object $1 => decodeBytes($1)}",
859859
}, {
860-
&api.Field{Name: "int32", JSONName: "int32", Typez: api.INT32_TYPE},
861-
"json['int32'] ?? 0",
860+
&api.Field{Name: "double", JSONName: "double", Typez: api.DOUBLE_TYPE},
861+
"switch (json['double']) { null => 0, Object $1 => decodeDouble($1)}",
862862
}, {
863863
&api.Field{Name: "fixed32", JSONName: "fixed32", Typez: api.FIXED32_TYPE},
864-
"json['fixed32'] ?? 0",
864+
"switch (json['fixed32']) { null => 0, Object $1 => decodeInt($1)}",
865+
}, {
866+
&api.Field{Name: "fixed64", JSONName: "fixed64", Typez: api.FIXED64_TYPE},
867+
"switch (json['fixed64']) { null => 0, Object $1 => decodeInt64($1)}",
868+
}, {
869+
&api.Field{Name: "float", JSONName: "float", Typez: api.FLOAT_TYPE},
870+
"switch (json['float']) { null => 0, Object $1 => decodeDouble($1)}",
871+
}, {
872+
&api.Field{Name: "int32", JSONName: "int32", Typez: api.INT32_TYPE},
873+
"switch (json['int32']) { null => 0, Object $1 => decodeInt($1)}",
874+
}, {
875+
&api.Field{Name: "int64", JSONName: "int64", Typez: api.INT64_TYPE},
876+
"switch (json['int64']) { null => 0, Object $1 => decodeInt64($1)}",
877+
}, {
878+
&api.Field{Name: "sfixed32", JSONName: "sfixed32", Typez: api.SFIXED32_TYPE},
879+
"switch (json['sfixed32']) { null => 0, Object $1 => decodeInt($1)}",
880+
}, {
881+
&api.Field{Name: "sfixed64", JSONName: "sfixed64", Typez: api.SFIXED64_TYPE},
882+
"switch (json['sfixed64']) { null => 0, Object $1 => decodeInt64($1)}",
883+
}, {
884+
&api.Field{Name: "sint64", JSONName: "sint64", Typez: api.SINT64_TYPE},
885+
"switch (json['sint64']) { null => 0, Object $1 => decodeInt64($1)}",
865886
}, {
866887
&api.Field{Name: "string", JSONName: "string", Typez: api.STRING_TYPE},
867-
"json['string'] ?? ''",
888+
"switch (json['string']) { null => '', Object $1 => decodeString($1)}",
889+
}, {
890+
&api.Field{Name: "uint32", JSONName: "uint32", Typez: api.UINT32_TYPE},
891+
"switch (json['uint32']) { null => 0, Object $1 => decodeInt($1)}",
892+
}, {
893+
&api.Field{Name: "uint64", JSONName: "uint64", Typez: api.UINT64_TYPE},
894+
"switch (json['uint64']) { null => 0, Object $1 => decodeInt64($1)}",
868895
},
869896

870897
// optional primitives
871898
{
872899
&api.Field{Name: "bool_opt", JSONName: "bool", Typez: api.BOOL_TYPE, Optional: true},
873-
"json['bool']",
900+
"switch (json['bool']) { null => null, Object $1 => decodeBool($1)}",
874901
}, {
875902
&api.Field{Name: "bytes_opt", JSONName: "bytes", Typez: api.BYTES_TYPE, Optional: true},
876-
"decodeBytes(json['bytes'])",
903+
"switch (json['bytes']) { null => null, Object $1 => decodeBytes($1)}",
904+
}, {
905+
&api.Field{Name: "double_opt", JSONName: "double", Typez: api.DOUBLE_TYPE, Optional: true},
906+
"switch (json['double']) { null => null, Object $1 => decodeDouble($1)}",
907+
}, {
908+
&api.Field{Name: "fixed64_opt", JSONName: "fixed64", Typez: api.FIXED64_TYPE, Optional: true},
909+
"switch (json['fixed64']) { null => null, Object $1 => decodeInt64($1)}",
910+
}, {
911+
&api.Field{Name: "float_opt", JSONName: "float", Typez: api.FLOAT_TYPE, Optional: true},
912+
"switch (json['float']) { null => null, Object $1 => decodeDouble($1)}",
877913
}, {
878914
&api.Field{Name: "int32_opt", JSONName: "int32", Typez: api.INT32_TYPE, Optional: true},
879-
"json['int32']",
915+
"switch (json['int32']) { null => null, Object $1 => decodeInt($1)}",
916+
}, {
917+
&api.Field{Name: "int64_opt", JSONName: "int64", Typez: api.INT64_TYPE, Optional: true},
918+
"switch (json['int64']) { null => null, Object $1 => decodeInt64($1)}",
919+
}, {
920+
&api.Field{Name: "sfixed32_opt", JSONName: "sfixed32", Typez: api.SFIXED32_TYPE, Optional: true},
921+
"switch (json['sfixed32']) { null => null, Object $1 => decodeInt($1)}",
922+
}, {
923+
&api.Field{Name: "sfixed64_opt", JSONName: "sfixed64", Typez: api.SFIXED64_TYPE, Optional: true},
924+
"switch (json['sfixed64']) { null => null, Object $1 => decodeInt64($1)}",
925+
}, {
926+
&api.Field{Name: "sint64_opt", JSONName: "sint64", Typez: api.SINT64_TYPE, Optional: true},
927+
"switch (json['sint64']) { null => null, Object $1 => decodeInt64($1)}",
880928
}, {
881929
&api.Field{Name: "string_opt", JSONName: "string", Typez: api.STRING_TYPE, Optional: true},
882-
"json['string']",
930+
"switch (json['string']) { null => null, Object $1 => decodeString($1)}",
931+
}, {
932+
&api.Field{Name: "uint32_opt", JSONName: "uint32", Typez: api.UINT32_TYPE, Optional: true},
933+
"switch (json['uint32']) { null => null, Object $1 => decodeInt($1)}",
934+
}, {
935+
&api.Field{Name: "uint64_opt", JSONName: "uint64", Typez: api.UINT64_TYPE, Optional: true},
936+
"switch (json['uint64']) { null => null, Object $1 => decodeInt64($1)}",
883937
},
884938

885939
// one ofs
886940
{
887941
&api.Field{Name: "bool", JSONName: "bool", Typez: api.BOOL_TYPE, IsOneOf: true},
888-
"json['bool']",
942+
"switch (json['bool']) { null => null, Object $1 => decodeBool($1)}",
889943
},
890944

891945
// repeated primitives
892946
{
893947
&api.Field{Name: "boolList", JSONName: "boolList", Typez: api.BOOL_TYPE, Repeated: true},
894-
"decodeList(json['boolList']) ?? []",
948+
"switch (json['boolList']) { null => [], List<Object?> $1 => [for (final i in $1) decodeBool(i)], _ => throw FormatException('\"boolList\" is not a list') }",
895949
}, {
896950
&api.Field{Name: "bytesList", JSONName: "bytesList", Typez: api.BYTES_TYPE, Repeated: true},
897-
"decodeListBytes(json['bytesList']) ?? []",
951+
"switch (json['bytesList']) { null => [], List<Object?> $1 => [for (final i in $1) decodeBytes(i)], _ => throw FormatException('\"bytesList\" is not a list') }",
952+
}, {
953+
&api.Field{Name: "doubleList", JSONName: "doubleList", Typez: api.DOUBLE_TYPE, Repeated: true},
954+
"switch (json['doubleList']) { null => [], List<Object?> $1 => [for (final i in $1) decodeDouble(i)], _ => throw FormatException('\"doubleList\" is not a list') }",
955+
}, {
956+
&api.Field{Name: "fixed32List", JSONName: "fixed32List", Typez: api.FIXED32_TYPE, Repeated: true},
957+
"switch (json['fixed32List']) { null => [], List<Object?> $1 => [for (final i in $1) decodeInt(i)], _ => throw FormatException('\"fixed32List\" is not a list') }",
898958
}, {
899959
&api.Field{Name: "int32List", JSONName: "int32List", Typez: api.INT32_TYPE, Repeated: true},
900-
"decodeList(json['int32List']) ?? []",
960+
"switch (json['int32List']) { null => [], List<Object?> $1 => [for (final i in $1) decodeInt(i)], _ => throw FormatException('\"int32List\" is not a list') }",
901961
}, {
902962
&api.Field{Name: "stringList", JSONName: "stringList", Typez: api.STRING_TYPE, Repeated: true},
903-
"decodeList(json['stringList']) ?? []",
963+
"switch (json['stringList']) { null => [], List<Object?> $1 => [for (final i in $1) decodeString(i)], _ => throw FormatException('\"stringList\" is not a list') }",
904964
},
905965

906966
// repeated primitives w/ optional
907967
{
908968
&api.Field{Name: "int32List_opt", JSONName: "int32List", Typez: api.INT32_TYPE, Repeated: true, Optional: true},
909-
"decodeList(json['int32List']) ?? []",
969+
"switch (json['int32List']) { null => [], List<Object?> $1 => [for (final i in $1) decodeInt(i)], _ => throw FormatException('\"int32List\" is not a list') }",
910970
},
911971

912972
// enums
913973
{
914974
&api.Field{Name: "message", JSONName: "message", Typez: api.ENUM_TYPE, TypezID: enumState.ID},
915-
"decodeEnum(json['message'], State.fromJson) ?? State.$default",
975+
"switch (json['message']) { null => State.$default, Object $1 => State.fromJson($1)}",
916976
},
917977
{
918978
&api.Field{Name: "message", JSONName: "message", Typez: api.ENUM_TYPE, TypezID: foreignEnumState.ID},
919-
"decodeEnum(json['message'], foo.ForeignEnum.fromJson) ?? foo.ForeignEnum.$default",
979+
"switch (json['message']) { null => foo.ForeignEnum.$default, Object $1 => foo.ForeignEnum.fromJson($1)}",
920980
},
921981

922982
// messages
923983
{
924984
&api.Field{Name: "message", JSONName: "message", Typez: api.MESSAGE_TYPE, TypezID: secret.ID},
925-
"decode(json['message'], Secret.fromJson)",
985+
"switch (json['message']) { null => null, Object $1 => Secret.fromJson($1)}",
926986
},
927987
{
928988
&api.Field{Name: "message", JSONName: "message", Typez: api.MESSAGE_TYPE, TypezID: foreignMessage.ID},
929-
"decode(json['message'], foo.Foo.fromJson)",
989+
"switch (json['message']) { null => null, Object $1 => foo.Foo.fromJson($1)}",
930990
},
931991
{
932992
// Custom encoding.
933993
&api.Field{Name: "message", JSONName: "message", Typez: api.MESSAGE_TYPE, TypezID: ".google.protobuf.Duration"},
934-
"decodeCustom(json['message'], Duration.fromJson)",
994+
"switch (json['message']) { null => null, Object $1 => Duration.fromJson($1)}",
935995
},
936996
{
937997
// Map of bytes.
938998
&api.Field{Name: "message", JSONName: "message", Map: true, Typez: api.MESSAGE_TYPE, TypezID: mapStringToBytes.ID},
939-
"decodeMapBytes(json['message']) ?? {}",
999+
"switch (json['message']) { null => {}, Map<String, Object?> $1 => {for (final e in $1.entries) decodeString(e.key): decodeBytes(e.value)}, _ => throw FormatException('\"message\" is not an object') }",
9401000
},
9411001
} {
9421002
t.Run(test.field.Name, func(t *testing.T) {

‎internal/sidekick/dart/templates/lib/enum.mustache‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ final class {{Codec.Name}} extends {{Codec.Model.Codec.ProtoPrefix}}ProtoEnum {
3232

3333
const {{Codec.Name}}(super.value);
3434

35-
factory {{Codec.Name}}.fromJson(String json) => {{Codec.Name}}(json);
35+
factory {{Codec.Name}}.fromJson(Object? json) => {{Codec.Name}}(json as String);
3636

3737
bool get isNotDefault => this != $default;
3838

‎internal/sidekick/dart/templates/lib/main.dart.mustache‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ limitations under the License.
2525
{{/Codec.DocLines}}
2626
library;
2727

28-
// ignore_for_file: argument_type_not_assignable {{! dynamic is used for protobuf messages }}
2928
// ignore_for_file: avoid_unused_constructor_parameters {{! `fromJson` may not use its arguments if the message is empty }}
3029
// ignore_for_file: camel_case_types {{! Nested messages have the parent/child separated by an underscore }}
3130
// ignore_for_file: comment_references {{! TODO(#25): improve the generated dartdocs }}

‎internal/sidekick/dart/templates/lib/message.mustache‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,23 @@ final class {{Codec.Name}} extends {{Codec.Model.Codec.ProtoPrefix}}ProtoMessage
5050
super(fullyQualifiedName){{Codec.ConstructorBody}}
5151

5252
{{#Codec.HasCustomEncoding}}
53-
factory {{Codec.Name}}.fromJson(Object json) => _{{Codec.Name}}Helper.decode(json);
53+
factory {{Codec.Name}}.fromJson(Object? json) => _{{Codec.Name}}Helper.decode(json);
5454
{{/Codec.HasCustomEncoding}}
5555
{{^Codec.HasCustomEncoding}}
56-
factory {{Codec.Name}}.fromJson(Map<String, dynamic> json) =>
57-
{{Codec.Name}}(
58-
{{#Fields}}
59-
{{{Codec.Name}}}: {{{Codec.FromJson}}},
60-
{{/Fields}}
61-
);
56+
factory {{Codec.Name}}.fromJson(Object? j)
57+
{{#Codec.HasFields}}
58+
{
59+
final json = j as Map<String, Object?>;
60+
return {{Codec.Name}}(
61+
{{#Fields}}
62+
{{{Codec.Name}}}: {{{Codec.FromJson}}},
63+
{{/Fields}}
64+
);
65+
}
66+
{{/Codec.HasFields}}
67+
{{^Codec.HasFields}}
68+
=> {{Codec.Name}}();
69+
{{/Codec.HasFields}}
6270
{{/Codec.HasCustomEncoding}}
6371

6472
@override

0 commit comments

Comments
 (0)