fix(internal): skip write LastGeneratedCommit field to json (#2293)

`last_generated_commit` field should be omitted from all generated JSON
request files: release-init-request.json, configure-request.json,
generate-request.json, and build-request.json. Ref
[language-onboarding.md](https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md)

Fixes #2081

Author: zhumin8

internal/config/state.go

@@ -110,7 +110,7 @@ type LibraryState struct {
 	// The last released version of the library, following SemVer.
 	Version string `yaml:"version" json:"version"`
 	// The commit hash from the API definition repository at which the library was last generated.
-	LastGeneratedCommit string `yaml:"last_generated_commit" json:"last_generated_commit"`
+	LastGeneratedCommit string `yaml:"last_generated_commit" json:"-"`
 	// The changes from the language repository since the library was last released.
 	// This field is ignored when writing to state.yaml.
 	Changes []*conventionalcommits.ConventionalCommit `yaml:"-" json:"changes,omitempty"`

internal/librarian/state_test.go

@@ -353,9 +353,8 @@ func TestReadLibraryState(t *testing.T) {
 			name:     "successful load content",
 			filename: "successful-unmarshal-libraryState.json",
 			want: &config.LibraryState{
-				ID:                  "google-cloud-go",
-				Version:             "1.0.0",
-				LastGeneratedCommit: "abcd123",
+				ID:      "google-cloud-go",
+				Version: "1.0.0",
 				APIs: []*config.API{
 					{
 						Path:          "google/cloud/compute/v1",

testdata/docker/release-init-request/release-init-request.json

@@ -4,7 +4,6 @@
     {
       "id": "my-library",
       "version": "1.1.0",
-      "last_generated_commit": "",
       "changes": [
         {
           "type": "feat",

testdata/test-read-library-state/successful-unmarshal-libraryState.json

@@ -1,7 +1,6 @@
 {
   "id": "google-cloud-go",
   "version": "1.0.0",
-  "last_generated_commit": "abcd123",
   "apis": [
     {
       "path": "google/cloud/compute/v1",
@@ -17,4 +16,4 @@
   "remove_regex": [
     "example-remove-regex"
   ]
-}
+}

testdata/test-read-library-state/unmarshal-libraryState-with-error-msg.json

@@ -1,7 +1,6 @@
 {
   "id": "google-cloud-go",
   "version": "1.0.0",
-  "last_generated_commit": "abcd123",
   "apis": [
     {
       "path": "google/cloud/compute/v1",
@@ -12,4 +11,4 @@
   "preserve_regex": [],
   "remove_regex": [],
   "error": "simulated error message"
-}
+}

testdata/test-write-librarian-state/write-librarian-state-example.json

@@ -4,7 +4,6 @@
     {
       "id": "google-cloud-go",
       "version": "1.0.0",
-      "last_generated_commit": "abcd123",
       "apis": [
         {
           "path": "google/cloud/compute/v1",
@@ -25,7 +24,6 @@
     {
       "id": "google-cloud-storage",
       "version": "1.2.3",
-      "last_generated_commit": "",
       "apis": [
         {
           "path": "google/storage/v1",
@@ -38,4 +36,4 @@
       "remove_regex": null
     }
   ]
-}
+}

testdata/test-write-library-state/successful-marshaling-and-writing.json

@@ -1,7 +1,6 @@
 {
   "id": "google-cloud-go",
   "version": "1.0.0",
-  "last_generated_commit": "abcd123",
   "apis": [
     {
       "path": "google/cloud/compute/v1",
@@ -18,4 +17,4 @@
   "remove_regex": [
     "example-remove-regex"
   ]
-}
+}