Skip to content

Commit b300a4e

Browse files
authored
fix(librarian): resolve issue where onboarded library can't be released (#2632)
Fixes #2629
1 parent b3ac7b4 commit b300a4e

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

internal/librarian/generate_pull_request_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,10 +600,15 @@ func TestFormatOnboardPRBody(t *testing.T) {
600600
},
601601
api: "path/to",
602602
library: "one-library",
603-
want: fmt.Sprintf(`feat: onboard a new library
603+
want: fmt.Sprintf(`BEGIN_COMMIT_OVERRIDE
604+
605+
feat: onboard a new library
604606
605607
PiperOrigin-RevId: 98765
606608
Library-IDs: one-library
609+
610+
END_COMMIT_OVERRIDE
611+
607612
Librarian Version: %s
608613
Language Image: %s`,
609614
librarianVersion, "go:1.21"),

internal/librarian/release_notes.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,15 @@ Language Image: {{.ImageVersion}}
136136
{{- end }}
137137
`))
138138

139-
onboardingBodyTemplate = template.Must(template.New("onboardingBody").Parse(`feat: onboard a new library
139+
onboardingBodyTemplate = template.Must(template.New("onboardingBody").Parse(`BEGIN_COMMIT_OVERRIDE
140+
141+
feat: onboard a new library
140142
141143
PiperOrigin-RevId: {{.PiperID}}
142144
Library-IDs: {{.LibraryID}}
145+
146+
END_COMMIT_OVERRIDE
147+
143148
Librarian Version: {{.LibrarianVersion}}
144149
Language Image: {{.ImageVersion}}
145150
`))

0 commit comments

Comments
 (0)