Skip to content

Commit b748028

Browse files
authored
doc: update CONTRIBUTING.md with test health guidelines (#2703)
Add guidelines to CONTRIBUTING.md that tests should never fail at HEAD.
1 parent 9689ec2 commit b748028

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

CONTRIBUTING.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,3 +370,17 @@ When reviewing a pull request:
370370
- The
371371
[user-review-requested:@me](https://github.com/googleapis/librarian/pulls?q=is%3Apr+is%3Aopen+user-review-requested%3A%40me)
372372
search view is helpful for tracking PRs awaiting your review.
373+
374+
### Test Health
375+
376+
All pull requests require passing CI checks to be merged.
377+
378+
The main branch must always be stable, and tests should never fail at HEAD. A
379+
red build on main is a critical issue that must be fixed immediately. If tests
380+
become flaky or the
381+
[main branch](https://github.com/googleapis/librarian/commits/main) is not
382+
consistently green, the team's top priority should shift to restoring
383+
stability.
384+
385+
All other development should be deprioritized until green builds can
386+
be guaranteed.

0 commit comments

Comments
 (0)