Skip to content

Commit c2a26dc

Browse files
authored
fix: change librarian volume to read-write in build command (#1772)
Fixes #1771
1 parent b2e2c93 commit c2a26dc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

internal/docker/docker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ func (c *Docker) Build(ctx context.Context, request *BuildRequest) error {
205205

206206
librarianDir := filepath.Join(request.RepoDir, config.LibrarianDir)
207207
mounts := []string{
208-
fmt.Sprintf("%s:/librarian:ro", librarianDir), // readonly volume
208+
fmt.Sprintf("%s:/librarian", librarianDir),
209209
fmt.Sprintf("%s:/repo", request.RepoDir),
210210
}
211211
commandArgs := []string{

internal/docker/docker_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ func TestDockerRun(t *testing.T) {
197197
},
198198
want: []string{
199199
"run", "--rm",
200-
"-v", fmt.Sprintf("%s/.librarian:/librarian:ro", repoDir),
200+
"-v", fmt.Sprintf("%s/.librarian:/librarian", repoDir),
201201
"-v", fmt.Sprintf("%s:/repo", repoDir),
202202
testImage,
203203
string(CommandBuild),

0 commit comments

Comments
 (0)