fix(internal/librarian): use t.Fatal in tests for proper failure handling (#2759)

zhumin8 · web-flow · commit cdabb2870b37 · 2025-11-03T14:46:59.000-05:00
Use t.Fatal instead of log.Fatal in TestRun. Came across this when working on #2754.
diff --git a/internal/librarian/librarian_test.go b/internal/librarian/librarian_test.go
@@ -19,7 +19,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"log"
 	"log/slog"
 	"math/rand"
 	"os"
@@ -40,7 +39,7 @@ import (
 
 func TestRun(t *testing.T) {
 	if err := Run(t.Context(), []string{"version"}...); err != nil {
-		log.Fatal(err)
+		t.Fatal(err)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ import (`
`19`	`19`	`"context"`
`20`	`20`	`"fmt"`
`21`	`21`	`"io"`
`22`		`- "log"`
`23`	`22`	`"log/slog"`
`24`	`23`	`"math/rand"`
`25`	`24`	`"os"`
`@@ -40,7 +39,7 @@ import (`
`40`	`39`
`41`	`40`	`func TestRun(t *testing.T) {`
`42`	`41`	`if err := Run(t.Context(), []string{"version"}...); err != nil {`
`43`		`- log.Fatal(err)`
	`42`	`+ t.Fatal(err)`
`44`	`43`	`}`
`45`	`44`	`}`
`46`	`45`