fix: username is required, but ignored for GitHub's https push (#1784)

chingor13 · web-flow · commit d40c87cf9257 · 2025-08-19T19:59:37.000Z
diff --git a/internal/gitrepo/gitrepo.go b/internal/gitrepo/gitrepo.go
@@ -405,6 +405,9 @@ func (r *LocalRepository) Push(branchName string) error {
 	if r.gitPassword != "" {
 		slog.Info("Authenticating with basic auth")
 		auth = &httpAuth.BasicAuth{
+			// GitHub authentication needs the username set to a non-empty value, but
+			// it does not need to match the token
+			Username: "cloud-sdk-librarian",
 			Password: r.gitPassword,
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -405,6 +405,9 @@ func (r *LocalRepository) Push(branchName string) error {`
`405`	`405`	`if r.gitPassword != "" {`
`406`	`406`	`slog.Info("Authenticating with basic auth")`
`407`	`407`	`auth = &httpAuth.BasicAuth{`
	`408`	`+ // GitHub authentication needs the username set to a non-empty value, but`
	`409`	`+ // it does not need to match the token`
	`410`	`+ Username: "cloud-sdk-librarian",`
`408`	`411`	`Password: r.gitPassword,`
`409`	`412`	`}`
`410`	`413`	`}`