Commit f05b7bb
authored
fix(devtools/cmd/migrate-sidekick): migrate to Library.Roots instead of RustCrate.Roots (#3332)
Migrate roots info into Library.Roots instead of Library.Rust.Roots.
Migration script created a different struct as expected by
[toSidekickConfig](https://github.com/googleapis/librarian/blob/main/internal/librarian/internal/rust/codec.go#L25).
There is confusion that both of these Roots existed in config. Removed
Library.Rust.Roots as I expect this should not be Rust specific.
Expected showcase config after migration:
```
- name: google-cloud-showcase-v1beta1
version: 1.0.0
channels:
- path: schema/google/showcase/v1beta1
copyright_year: "2025"
output: src/generated/showcase
roots:
- showcase
- googleapis
rust:
detailed_tracing_attributes: true
skip_publish: true
```
Local run for both `google-cloud-showcase-v1beta1` and
`google-cloud-compute-v1` succeed after this change. (compute generate
produced diffs, filing different issue for it.)
Fix #3324, #33291 parent fd24725 commit f05b7bb
File tree
3 files changed
+4
-6
lines changed- devtools/cmd/migrate-sidekick
- internal/config
3 files changed
+4
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
386 | | - | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
387 | 389 | | |
388 | 390 | | |
389 | 391 | | |
| |||
441 | 443 | | |
442 | 444 | | |
443 | 445 | | |
444 | | - | |
445 | 446 | | |
446 | 447 | | |
447 | 448 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| 189 | + | |
189 | 190 | | |
190 | 191 | | |
191 | 192 | | |
| |||
197 | 198 | | |
198 | 199 | | |
199 | 200 | | |
200 | | - | |
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | 136 | | |
140 | 137 | | |
141 | 138 | | |
| |||
0 commit comments