Skip to content

Commit aa001ba

Browse files
authored
chore: pick tools config version from cloudbuild.yaml (#68)
* chore: pick tools config version from cloudbuild.yaml * Update e2e_test.go * Update tbgenkit_test.go
1 parent 6caa497 commit aa001ba

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

core/e2e_test.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@ import (
3131

3232
// Global variables to hold session-scoped "fixtures"
3333
var (
34-
projectID string = getEnvVar("GOOGLE_CLOUD_PROJECT")
35-
toolboxVersion string = getEnvVar("TOOLBOX_VERSION")
36-
authToken1 string
37-
authToken2 string
34+
projectID string = getEnvVar("GOOGLE_CLOUD_PROJECT")
35+
toolboxVersion string = getEnvVar("TOOLBOX_VERSION")
36+
authToken1 string
37+
authToken2 string
38+
manifestVersion string = getEnvVar("TOOLBOX_MANIFEST_VERSION")
3839
)
3940

4041
func TestMain(m *testing.M) {
@@ -43,7 +44,7 @@ func TestMain(m *testing.M) {
4344

4445
// Get secrets and auth tokens
4546
log.Println("Fetching secrets and auth tokens...")
46-
toolsManifestContent := accessSecretVersion(ctx, projectID, "sdk_testing_tools", "34")
47+
toolsManifestContent := accessSecretVersion(ctx, projectID, "sdk_testing_tools", manifestVersion)
4748
clientID1 := accessSecretVersion(ctx, projectID, "sdk_testing_client1", "latest")
4849
clientID2 := accessSecretVersion(ctx, projectID, "sdk_testing_client2", "latest")
4950
authToken1 = getAuthToken(ctx, clientID1)

integration.cloudbuild.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ steps:
4242
- "GOPATH=/gopath"
4343
- TOOLBOX_VERSION=$_TOOLBOX_VERSION
4444
- GOOGLE_CLOUD_PROJECT=$PROJECT_ID
45+
- TOOLBOX_MANIFEST_VERSION=$_TOOLBOX_MANIFEST_VERSION
4546
volumes:
4647
- name: "go"
4748
path: "/gopath"
@@ -55,6 +56,7 @@ steps:
5556
- "GOPATH=/gopath"
5657
- TOOLBOX_VERSION=$_TOOLBOX_VERSION
5758
- GOOGLE_CLOUD_PROJECT=$PROJECT_ID
59+
- TOOLBOX_MANIFEST_VERSION=$_TOOLBOX_MANIFEST_VERSION
5860
volumes:
5961
- name: "go"
6062
path: "/gopath"
@@ -65,3 +67,4 @@ options:
6567
logging: CLOUD_LOGGING_ONLY
6668
substitutions:
6769
_TOOLBOX_VERSION: '0.12.0'
70+
_TOOLBOX_MANIFEST_VERSION: '34'

tbgenkit/tbgenkit_test.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@ import (
3131

3232
// Global variables to hold session-scoped "fixtures"
3333
var (
34-
projectID string = getEnvVar("GOOGLE_CLOUD_PROJECT")
35-
toolboxVersion string = getEnvVar("TOOLBOX_VERSION")
36-
authToken1 string
37-
authToken2 string
34+
projectID string = getEnvVar("GOOGLE_CLOUD_PROJECT")
35+
toolboxVersion string = getEnvVar("TOOLBOX_VERSION")
36+
authToken1 string
37+
authToken2 string
38+
manifestVersion string = getEnvVar("TOOLBOX_MANIFEST_VERSION")
3839
)
3940

4041
func TestMain(m *testing.M) {
@@ -43,7 +44,7 @@ func TestMain(m *testing.M) {
4344

4445
// Get secrets and auth tokens
4546
log.Println("Fetching secrets and auth tokens...")
46-
toolsManifestContent := accessSecretVersion(ctx, projectID, "sdk_testing_tools", "34")
47+
toolsManifestContent := accessSecretVersion(ctx, projectID, "sdk_testing_tools", manifestVersion)
4748
clientID1 := accessSecretVersion(ctx, projectID, "sdk_testing_client1", "latest")
4849
clientID2 := accessSecretVersion(ctx, projectID, "sdk_testing_client2", "latest")
4950
authToken1 = getAuthToken(ctx, clientID1)

0 commit comments

Comments
 (0)