chore: Add better assert condition for a flaky test (#27)

* chore: Add better assert condition for a flaky test

This particular test was flaky as the loadToolset runs an iteration through the map of Tools and the map iteration order is intentionally randomized.

This assert condition will correctly catch the error even if the map iteration order is random.

* minor fix

* Update client_test.go

Author: dishaprakash

core/client_test.go

@@ -334,7 +334,16 @@ func TestLoadToolAndLoadToolset(t *testing.T) {
 			t.Fatal("Expected an error for unused auth token in strict mode, but got nil")
 		}
 		// In strict mode, the error is reported for the first tool it doesn't apply to
-		if !strings.Contains(err.Error(), "validation failed for tool") {
+		// Since the order of tools in a map is non deterministic
+		// we will check for errors fro both tools.
+		errStr := err.Error()
+		isToolAError := strings.Contains(errStr, "validation failed for tool 'toolA'") &&
+			strings.Contains(errStr, "unused-auth") &&
+			strings.Contains(errStr, "github")
+
+		isToolBError := strings.Contains(errStr, "no parameter named 'param1' found on tool 'toolB'")
+
+		if !(isToolAError || isToolBError) {
 			t.Errorf("Incorrect error for unused auth token in strict mode. Got: %v", err)
 		}
 	})