remove run_as_sync and run_as_async methods

Author: twishabansal

packages/toolbox-core/src/toolbox_core/sync_client.py

@@ -70,26 +70,6 @@ async def __start_session() -> None:
             raise ValueError("Session cannot be None.")
         self.__async_client = ToolboxClient(url, self.__class__.__session)
 
-    def __run_as_sync(self, coro: Awaitable[T]) -> T:
-        """Run an async coroutine synchronously"""
-        if not self.__loop:
-            raise Exception(
-                "Cannot call synchronous methods before the background loop is initialized."
-            )
-        return asyncio.run_coroutine_threadsafe(coro, self.__loop).result()
-
-    async def __run_as_async(self, coro: Awaitable[T]) -> T:
-        """Run an async coroutine asynchronously"""
-
-        # If a loop has not been provided, attempt to run in current thread.
-        if not self.__loop:
-            return await coro
-
-        # Otherwise, run in the background thread.
-        return await asyncio.wrap_future(
-            asyncio.run_coroutine_threadsafe(coro, self.__loop)
-        )
-
     def close(self):
         """
         Synchronously closes the underlying client session. Doing so will cause
@@ -100,7 +80,7 @@ def close(self):
         attempt to close it.
         """
         coro = self.__session.close()
-        self.__run_as_sync(coro)
+        asyncio.run_coroutine_threadsafe(coro, self.__loop).result()
 
     def load_tool(
         self,
@@ -127,10 +107,8 @@ def load_tool(
                 for execution. The specific arguments and behavior of the callable
                 depend on the tool itself.
         """
-
-        async_tool = self.__run_as_sync(
-            self.__async_client.load_tool(name, auth_token_getters, bound_params)
-        )
+        coro = self.__async_client.load_tool(name, auth_token_getters, bound_params)
+        async_tool = asyncio.run_coroutine_threadsafe(coro, self.__loop).result()
 
         if not self.__loop or not self.__thread:
             raise ValueError("Background loop or thread cannot be None.")
@@ -156,10 +134,8 @@ def load_toolset(
             list[ToolboxSyncTool]: A list of callables, one for each tool defined
             in the toolset.
         """
-
-        async_tools = self.__run_as_sync(
-            self.__async_client.load_toolset(name, auth_token_getters, bound_params)
-        )
+        coro = self.__async_client.load_toolset(name, auth_token_getters, bound_params)
+        async_tools = asyncio.run_coroutine_threadsafe(coro, self.__loop).result()
 
         if not self.__loop or not self.__thread:
             raise ValueError("Background loop or thread cannot be None.")

packages/toolbox-core/src/toolbox_core/sync_tool.py

@@ -62,26 +62,6 @@ def __init__(
         self.__annotations__ = self.__async_tool.__annotations__
         # TODO: self.__qualname__ ?? (Consider if needed)
 
-    def __run_as_sync(self, coro: Awaitable[T]) -> T:
-        """Run an async coroutine synchronously"""
-        if not self.__loop:
-            raise Exception(
-                "Cannot call synchronous methods before the background loop is initialized."
-            )
-        return asyncio.run_coroutine_threadsafe(coro, self.__loop).result()
-
-    async def __run_as_async(self, coro: Awaitable[T]) -> T:
-        """Run an async coroutine asynchronously"""
-
-        # If a loop has not been provided, attempt to run in current thread.
-        if not self.__loop:
-            return await coro
-
-        # Otherwise, run in the background thread.
-        return await asyncio.wrap_future(
-            asyncio.run_coroutine_threadsafe(coro, self.__loop)
-        )
-
     def __call__(self, *args: Any, **kwargs: Any) -> str:
         """
         Synchronously calls the remote tool with the provided arguments.
@@ -96,7 +76,8 @@ def __call__(self, *args: Any, **kwargs: Any) -> str:
         Returns:
             The string result returned by the remote tool execution.
         """
-        return self.__run_as_sync(self.__async_tool(*args, **kwargs))
+        coro = self.__async_tool(*args, **kwargs)
+        return asyncio.run_coroutine_threadsafe(coro, self.__loop).result()
 
     def add_auth_token_getters(
         self,