fix: Remove properties exposing internal state from sync tool

Author: anubhav756

packages/toolbox-core/src/toolbox_core/sync_tool.py

@@ -68,18 +68,6 @@ def __init__(
             f"{self.__class__.__qualname__}.{self.__async_tool.__name__}"
         )
 
-    @property
-    def _async_tool(self) -> ToolboxTool:
-        return self.__async_tool
-
-    @property
-    def _loop(self) -> AbstractEventLoop:
-        return self.__loop
-
-    @property
-    def _thread(self) -> Thread:
-        return self.__thread
-
     @property
     def __name__(self) -> str:
         return self.__async_tool.__name__

packages/toolbox-core/tests/test_sync_client.py

@@ -235,41 +235,6 @@ def test_sync_load_toolset_success(
     assert result1 == f"{TOOL1_NAME}_ok"
 
 
-def test_sync_tool_internal_properties(aioresponses, tool_schema_minimal, sync_client):
-    """
-    Tests that the internal properties _async_tool, _loop, and _thread
-    of a ToolboxSyncTool instance are correctly initialized and accessible.
-    This directly covers the respective @property methods in ToolboxSyncTool.
-    """
-    TOOL_NAME = "test_tool_for_internal_properties"
-    mock_tool_load(aioresponses, TOOL_NAME, tool_schema_minimal)
-
-    loaded_sync_tool = sync_client.load_tool(TOOL_NAME)
-
-    assert isinstance(loaded_sync_tool, ToolboxSyncTool)
-
-    # 1. Test the _async_tool property
-    internal_async_tool = loaded_sync_tool._async_tool
-    assert isinstance(internal_async_tool, ToolboxTool)
-    assert internal_async_tool.__name__ == TOOL_NAME
-
-    # 2. Test the _loop property
-    internal_loop = loaded_sync_tool._loop
-    assert isinstance(internal_loop, AbstractEventLoop)
-    assert internal_loop is sync_client._ToolboxSyncClient__loop
-    assert (
-        internal_loop.is_running()
-    ), "The event loop used by ToolboxSyncTool should be running."
-
-    # 3. Test the _thread property
-    internal_thread = loaded_sync_tool._thread
-    assert isinstance(internal_thread, Thread)
-    assert internal_thread is sync_client._ToolboxSyncClient__thread
-    assert (
-        internal_thread.is_alive()
-    ), "The thread used by ToolboxSyncTool should be alive."
-
-
 def test_sync_invoke_tool_server_error(aioresponses, test_tool_str_schema, sync_client):
     TOOL_NAME = "sync_server_error_tool"
     ERROR_MESSAGE = "Simulated Server Error for Sync Client"