clean tests

Author: twishabansal

packages/toolbox-core/tests/test_auth_methods.py

@@ -12,12 +12,25 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import google.auth.exceptions
-import pytest
 from unittest.mock import patch, AsyncMock, MagicMock
 
+import pytest
+import google.auth.exceptions
+
 from toolbox_core import auth_methods
 
+# Constants for test values
+MOCK_ASYNC_ID_TOKEN = "test_async_id_token_123"
+MOCK_SYNC_ID_TOKEN = "test_sync_id_token_456"
+MOCK_PROJECT_ID = "test-project"
+
+# Error Messages
+ADC_NOT_FOUND_MSG = "ADC not found"
+TOKEN_REFRESH_FAILED_MSG = "Token refresh failed"
+SYNC_ADC_NOT_FOUND_MSG = "Sync ADC not found"
+SYNC_TOKEN_REFRESH_FAILED_MSG = "Sync token refresh failed"
+
+
 @pytest.mark.asyncio
 @patch("toolbox_core.auth_methods.partial")
 @patch("toolbox_core.auth_methods._aiohttp_requests.Request")
@@ -30,22 +43,18 @@ async def test_aget_google_id_token_success(
     mock_partial,
 ):
     """
-    Test aget_google_id_token successfully retrieves and formats a token using pytest.
+    Test aget_google_id_token successfully retrieves and formats a token.
     """
-    # Setup mock for default_async() -> (creds, project_id)
     mock_creds_instance = AsyncMock()
-    mock_creds_instance.id_token = "test_async_id_token_123"
-    mock_default_async.return_value = (mock_creds_instance, "test-project")
+    mock_creds_instance.id_token = MOCK_ASYNC_ID_TOKEN
+    mock_default_async.return_value = (mock_creds_instance, MOCK_PROJECT_ID)
 
-    # Setup mock for _aiohttp_requests.Request()
     mock_aio_request_instance = MagicMock()
     mock_aiohttp_request_class.return_value = mock_aio_request_instance
 
-    # Setup mock for Credentials.before_request (class attribute used in partial)
     mock_unbound_before_request = MagicMock()
     mock_credentials_class.before_request = mock_unbound_before_request
 
-    # Setup mock for partial()
     mock_partial_object = MagicMock()
     mock_partial.return_value = mock_partial_object
 
@@ -59,22 +68,21 @@ async def test_aget_google_id_token_success(
         mock_unbound_before_request, mock_creds_instance
     )
     assert mock_creds_instance.before_request == mock_partial_object
-
-    assert token == "Bearer test_async_id_token_123"
+    assert token == f"Bearer {MOCK_ASYNC_ID_TOKEN}"
 
 
 @pytest.mark.asyncio
 @patch("toolbox_core.auth_methods.default_async")
 async def test_aget_google_id_token_default_credentials_error(mock_default_async):
     """
-    Test aget_google_id_token when default_async raises DefaultCredentialsError.
+    Test aget_google_id_token handles DefaultCredentialsError.
     """
     mock_default_async.side_effect = google.auth.exceptions.DefaultCredentialsError(
-        "ADC not found"
+        ADC_NOT_FOUND_MSG
     )
 
     with pytest.raises(
-        google.auth.exceptions.DefaultCredentialsError, match="ADC not found"
+        google.auth.exceptions.DefaultCredentialsError, match=ADC_NOT_FOUND_MSG
     ):
         await auth_methods.aget_google_id_token()
 
@@ -89,20 +97,19 @@ async def test_aget_google_id_token_refresh_error(
     mock_aiohttp_request_class,
 ):
     """
-    Test aget_google_id_token when creds.refresh raises RefreshError.
-    The `partial` call should not happen if refresh fails.
+    Test aget_google_id_token handles RefreshError.
     """
     mock_creds_instance = AsyncMock()
     mock_creds_instance.refresh.side_effect = google.auth.exceptions.RefreshError(
-        "Token refresh failed"
+        TOKEN_REFRESH_FAILED_MSG
     )
-    mock_default_async.return_value = (mock_creds_instance, "test-project")
+    mock_default_async.return_value = (mock_creds_instance, MOCK_PROJECT_ID)
 
     mock_aio_request_instance = MagicMock()
     mock_aiohttp_request_class.return_value = mock_aio_request_instance
 
     with pytest.raises(
-        google.auth.exceptions.RefreshError, match="Token refresh failed"
+        google.auth.exceptions.RefreshError, match=TOKEN_REFRESH_FAILED_MSG
     ):
         await auth_methods.aget_google_id_token()
 
@@ -122,18 +129,15 @@ def test_get_google_id_token_success(
     mock_request_class,
 ):
     """
-    Test get_google_id_token successfully retrieves and formats a token using pytest.
+    Test get_google_id_token successfully retrieves and formats a token.
     """
-    # Setup mock for google.auth.default() -> (credentials, project_id)
     mock_creds_instance = MagicMock()
-    mock_creds_instance.id_token = "test_sync_id_token_456"
-    mock_google_auth_default.return_value = (mock_creds_instance, "test-project")
+    mock_creds_instance.id_token = MOCK_SYNC_ID_TOKEN
+    mock_google_auth_default.return_value = (mock_creds_instance, MOCK_PROJECT_ID)
 
-    # Setup mock for AuthorizedSession()
     mock_session_instance = MagicMock()
     mock_authorized_session_class.return_value = mock_session_instance
 
-    # Setup mock for Request()
     mock_request_instance = MagicMock()
     mock_request_class.return_value = mock_request_instance
 
@@ -143,20 +147,20 @@ def test_get_google_id_token_success(
     mock_authorized_session_class.assert_called_once_with(mock_creds_instance)
     mock_request_class.assert_called_once_with(mock_session_instance)
     mock_creds_instance.refresh.assert_called_once_with(mock_request_instance)
-    assert token == "Bearer test_sync_id_token_456"
+    assert token == f"Bearer {MOCK_SYNC_ID_TOKEN}"
 
 
 @patch("toolbox_core.auth_methods.google.auth.default")
 def test_get_google_id_token_default_credentials_error(mock_google_auth_default):
     """
-    Test get_google_id_token when google.auth.default raises DefaultCredentialsError.
+    Test get_google_id_token handles DefaultCredentialsError.
     """
     mock_google_auth_default.side_effect = (
-        google.auth.exceptions.DefaultCredentialsError("Sync ADC not found")
+        google.auth.exceptions.DefaultCredentialsError(SYNC_ADC_NOT_FOUND_MSG)
     )
 
     with pytest.raises(
-        google.auth.exceptions.DefaultCredentialsError, match="Sync ADC not found"
+        google.auth.exceptions.DefaultCredentialsError, match=SYNC_ADC_NOT_FOUND_MSG
     ):
         auth_methods.get_google_id_token()
 
@@ -172,13 +176,13 @@ def test_get_google_id_token_refresh_error(
     mock_request_class,
 ):
     """
-    Test get_google_id_token when credentials.refresh raises RefreshError.
+    Test get_google_id_token handles RefreshError.
     """
     mock_creds_instance = MagicMock()
     mock_creds_instance.refresh.side_effect = google.auth.exceptions.RefreshError(
-        "Sync token refresh failed"
+        SYNC_TOKEN_REFRESH_FAILED_MSG
     )
-    mock_google_auth_default.return_value = (mock_creds_instance, "test-project")
+    mock_google_auth_default.return_value = (mock_creds_instance, MOCK_PROJECT_ID)
 
     mock_session_instance = MagicMock()
     mock_authorized_session_class.return_value = mock_session_instance
@@ -187,7 +191,7 @@ def test_get_google_id_token_refresh_error(
     mock_request_class.return_value = mock_request_instance
 
     with pytest.raises(
-        google.auth.exceptions.RefreshError, match="Sync token refresh failed"
+        google.auth.exceptions.RefreshError, match=SYNC_TOKEN_REFRESH_FAILED_MSG
     ):
         auth_methods.get_google_id_token()