Apply suggestions from code review

Co-authored-by: Kurtis Van Gent <[email protected]>
Co-authored-by: Anubhav Dhawan <[email protected]>

Author: 3 people

packages/toolbox-core/src/toolbox_core/sync_client.py

@@ -65,7 +65,7 @@ async def __start_session() -> None:
 
         coro = __start_session()
 
-        asyncio.run_coroutine_threadsafe(coro, ToolboxSyncClient.__loop).result()
+        asyncio.run_coroutine_threadsafe(__start_session(), ToolboxSyncClient.__loop).result()
 
         if not ToolboxSyncClient.__session:
             raise ValueError("Session cannot be None.")
@@ -114,6 +114,7 @@ def load_tool(
         Returns:
             ToolboxSyncTool: A synchronous callable object representing the loaded tool.
         """
+
         async_tool = self.__run_as_sync(
             self.__async_client.load_tool(tool_name, auth_token_getters, bound_params)
         )
@@ -142,6 +143,7 @@ def load_toolset(
             list[ToolboxSyncTool]: A list of synchronous callables, one for each
             tool defined in the toolset.
         """
+
         async_tools = self.__run_as_sync(
             self.__async_client.load_toolset(
                 toolset_name, auth_token_getters, bound_params

packages/toolbox-core/src/toolbox_core/sync_tool.py

@@ -41,6 +41,7 @@ def __init__(
         Args:
             async_tool: An instance of the asynchronous ToolboxTool.
         """
+
         if not isinstance(async_tool, ToolboxTool):
             raise TypeError("async_tool must be an instance of ToolboxTool")
 
@@ -109,6 +110,7 @@ def add_auth_token_getters(
         Returns:
             A new SyncToolboxTool instance wrapping the updated async tool.
         """
+
         new_async_tool = self.__async_tool.add_auth_token_getters(auth_token_getters)
         return ToolboxSyncTool(new_async_tool, self.__loop, self.__thread)
 
@@ -125,5 +127,6 @@ def bind_parameters(
          Returns:
              A new SyncToolboxTool instance wrapping the updated async tool.
         """
+
         new_async_tool = self.__async_tool.bind_parameters(bound_params)
         return ToolboxSyncTool(new_async_tool, self.__loop, self.__thread)

packages/toolbox-core/tests/test_sync_e2e.py

@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
 import pytest
 
 from toolbox_core.sync_client import ToolboxSyncClient