chore: Remove property exposing internal state from toolbox core tool

Author: anubhav756

packages/toolbox-core/src/toolbox_core/tool.py

@@ -159,10 +159,6 @@ def _auth_service_token_getters(self) -> Mapping[str, Callable[[], str]]:
     def _client_headers(self) -> Mapping[str, Union[Callable, Coroutine, str]]:
         return MappingProxyType(self.__client_headers)
 
-    @property
-    def _pydantic_model(self) -> type[BaseModel]:
-        return self.__pydantic_model
-
     def __copy(
         self,
         session: Optional[ClientSession] = None,

packages/toolbox-core/tests/test_tool.py

@@ -578,24 +578,6 @@ def test_toolbox_tool_underscore_client_headers_property(toolbox_tool: ToolboxTo
         client_headers["new_header"] = "new_value"
 
 
-def test_toolbox_tool_underscore_pydantic_model_property(toolbox_tool: ToolboxTool):
-    """Tests the _pydantic_model property returns the correct Pydantic model."""
-    pydantic_model = toolbox_tool._pydantic_model
-    assert issubclass(pydantic_model, BaseModel)
-    assert pydantic_model.__name__ == TEST_TOOL_NAME
-
-    # Test that the model can validate expected data
-    valid_data = {"message": "test", "count": 10}
-    validated_data = pydantic_model.model_validate(valid_data)
-    assert validated_data.message == "test"
-    assert validated_data.count == 10
-
-    # Test that the model raises ValidationError for invalid data
-    invalid_data = {"message": 123, "count": "not_an_int"}
-    with pytest.raises(ValidationError):
-        pydantic_model.model_validate(invalid_data)
-
-
 # --- Test for the HTTP Warning ---
 @pytest.mark.parametrize(
     "trigger_condition_params",

packages/toolbox-langchain/src/toolbox_langchain/async_tools.py

@@ -16,6 +16,7 @@
 
 from langchain_core.tools import BaseTool
 from toolbox_core.tool import ToolboxTool as ToolboxCoreTool
+from toolbox_core.utils import params_to_pydantic_model
 
 
 # This class is an internal implementation detail and is not exposed to the
@@ -43,7 +44,7 @@ def __init__(
         super().__init__(
             name=core_tool.__name__,
             description=core_tool.__doc__,
-            args_schema=core_tool._pydantic_model,
+            args_schema=params_to_pydantic_model(core_tool._name, core_tool._params),
         )
         self.__core_tool = core_tool